Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite): bump fee by at least 1 gwei #15838

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix(suite): bump fee by at least 1 gwei #15838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae3904e
fix(suite): bump fee by at least 1 gwei
enjojoy Dec 9, 2024
d3837b7
chore(suite): comment regardign a test case that should be covered in
enjojoy Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/suite/src/hooks/wallet/__fixtures__/useRbfForm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1050,4 +1050,4 @@ export const composeAndSign = [
// TODO: multiple inputs (select one for decrease)
// TODO: custom fee + set-max (decrease)
// TODO: mad clicking (composeDebounce)
// TODO: ethereum cases
// TODO: ethereum cases (don't forget to test when proposed network fee > previous fee and < previous fee + 1 )
2 changes: 1 addition & 1 deletion packages/suite/src/hooks/wallet/useRbfForm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const getEthereumFeeInfo = (info: FeeInfo, gasPrice: string) => {
const minFeeFromNetwork = new BigNumber(fromWei(info.levels[0].feePerUnit, 'gwei'));

const getFee = () => {
if (minFeeFromNetwork.lte(current)) {
if (minFeeFromNetwork.lte(current.plus(1))) {
return current.plus(1);
}

Expand Down
Loading