Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(solana): add support for Token-2022 tokens #15769

Closed

Conversation

MartinZemanik
Copy link
Contributor

This PR adds support for Solana Token-2022 tokens. This means:

  • Users can view Token-2022 tokens in the tokens list
  • Users can send Token-2022 tokens
  • Suite correctly parses sent and received transactions for Token-2022 tokens and displays them in the tx history

Screenshots:

Tokens list

tokens-list

Send token

send

Transaction history

tx-history-received tx-history-sent

@@ -44,6 +44,7 @@ export default class BlockchainEstimateFee extends AbstractMethod<'blockchainEst
{ name: 'to', type: 'string' },
{ name: 'txsize', type: 'number' },
{ name: 'isCreatingAccount', type: 'boolean' },
{ name: 'newTokenAccountProgramName', type: 'string' },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I add validation that it's one of ['spl-token', 'spl-token-2022']?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @MartinZemanik, would be great

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Unpopular package npm/@solana-program/[email protected] 🚫

View full report↗︎

Next steps

What are unpopular packages?

This package is not very popular.

Unpopular packages may have less maintenance and contain other problems.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@tomasklim
Copy link
Member

We merged the pr from our branch. Thank you! Closing #15902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants