Bump gas price at least by 1 gwei

[tomasklim]

Before the implementation of #13328, the gas price was always increased by at least one gwei compared to the previous transaction. However, after the fix, the bump fee can propose an increase of just 1 wei. To maintain a more consistent fee bump logic, we should ensure that the new gas price is not only adjusted to the current network gas price but also is at least 1 gwei higher than the previous gas price.

It should also fix this warning error (at least 2 gas price)

Screen.Recording.2024-07-28.at.20.50.06.mov

[enjojoy]

It already increases the gas by at least 1 gwei. I've also tested it with gas price higher than the proposed network gas and it's increased it by at least 1 gwei.

The current logic suggests that if the network gas is lower than the previous gas, the new gas will be increased by 1. Since it was already in gwei, it will be increased by 1 gwei.

const getEthereumFeeInfo = (info: FeeInfo, gasPrice: string) => {
    const current = new BigNumber(gasPrice);
    const minFeeFromNetwork = new BigNumber(fromWei(info.levels[0].feePerUnit, 'gwei'));

    const getFee = () => {
        if (minFeeFromNetwork.lte(current)) {
            return current.plus(1);
        }

        return minFeeFromNetwork;
    };

    const fee = getFee();

    // increase FeeLevel only if it's lower than predefined
    const levels = getFeeLevels('ethereum', info).map(l => ({
        ...l,
        feePerUnit: fee.toString(),
    }));

    return {
        ...info,
        levels,
        minFee: current.plus(1).toNumber(), // increase required minFee rate
    };
};

@tomasklim Please let me know if there is any other case in which the gas price can be increased by less than 1 gwei. Otherwise I would close the issue.

[tomasklim]

Note: The minimum should be configurable because of new L2 chains #15478

[tomasklim]

@enjojoy Nobody touched the code from the time this issue was created.

Current develop (I see difference only 0.1)

it is clear from the code you shared, that it can happen

    const getFee = () => {
        if (minFeeFromNetwork.lte(current)) {
            return current.plus(1);
        }

        return minFeeFromNetwork;
    };

Situation:
You send tx with gas price 10 current
Current network gas price is 10.5 minFeeFromNetwork

minFeeFromNetwork is gte than current

The gas price is set to 10.5, not to 11 (and as we update fees once per 10 block, it is better to have there a buffer)

It is incremented by 1 only in case the tx fee is higher than current gas price in the network (it can happen as we use legacy fees and also fees in suite can be old)

The inconsistency visible in the video is also still there.

[enjojoy]

@enjojoy Nobody touched the code from the time this issue was created.

Current develop (I see difference only 0.1)

it is clear from the code you shared, that it can happen

    const getFee = () => {
        if (minFeeFromNetwork.lte(current)) {
            return current.plus(1);
        }

        return minFeeFromNetwork;
    };

Situation: You send tx with gas price 10 current Current network gas price is 10.5 minFeeFromNetwork

minFeeFromNetwork is gte than current

The gas price is set to 10.5, not to 11 (and as we update fees once per 10 block, it is better to have there a buffer)

It is incremented by 1 only in case the tx fee is higher than current gas price in the network (it can happen as we use legacy fees and also fees in suite can be old)

The inconsistency visible in the video is also still there.

Got it 🙏🏻 Thank you. Didn't realize that the difference with the network proposed fee can be less that 1 gwei and then it's problematic. Usually the fees are pretty high.

[bosomt]

QA OK

Info:

• Suite version: desktop 25.1.0 (0b11679)
• Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/25.1.0 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
• OS: MacIntel
• Screen: 1512x982
• Device: Trezor T3T1 2.8.7 regular (revision e196413bb745443610211c325623ba7cee7309e9)
• Transport: BridgeTransport 2.0.33