Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eckhart share words and select word components #4618

Open
wants to merge 11 commits into
base: ui-eckhart
Choose a base branch
from
Open

Eckhart share words and select word components #4618

wants to merge 11 commits into from

Conversation

bieleluk
Copy link
Contributor

this PR:

  • renames new_show_share_words_delizia to new_show_share_words_extended because it will be used by eckhart as well
  • creates a full-screen and partial components for showing share words
  • creates a full-screen component for selecting a word

@bieleluk bieleluk requested a review from obrusvit February 12, 2025 12:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2025 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

obrusvit
obrusvit reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@obrusvit obrusvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments for discussion.

core/embed/rust/src/ui/layout_eckhart/component/mod.rs Outdated Show resolved Hide resolved
core/embed/rust/src/ui/layout_eckhart/component/share_words_screen.rs Outdated Show resolved Hide resolved
core/embed/rust/src/ui/layout_eckhart/component/share_words_screen.rs Outdated Show resolved Hide resolved
core/embed/rust/src/ui/layout_eckhart/component/share_words_screen.rs Outdated Show resolved Hide resolved
core/embed/rust/src/ui/layout_eckhart/component/share_words_screen.rs Outdated Show resolved Hide resolved
core/embed/rust/src/ui/layout_eckhart/component/share_words_screen.rs Outdated Show resolved Hide resolved
core/mocks/trezortranslate_keys.pyi Outdated Show resolved Hide resolved
core/embed/rust/src/ui/layout_eckhart/component/share_words_screen.rs Outdated Show resolved Hide resolved
@obrusvit
Copy link
Contributor

obrusvit commented Feb 13, 2025 •
edited
Loading

I added two comments to the code, not sure how to access them..
One is here:
be40fcf#r152505790
2nd:
be40fcf#r152505790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obrusvit obrusvit obrusvit left review comments

Assignees
No one assigned
Labels
None yet
Projects
Firmware
Status: 🔎 Needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bieleluk @obrusvit