Eckhart vertical menu improvement #4617
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bieleluk
changed the title
|
obrusvit
reviewed
Feb 12, 2025
| @@ -37,6 +37,8 @@ pub struct Button { | |||
|
|
|||
| impl Button { | |||
| pub const BASELINE_OFFSET: Offset = Offset::new(2, 6); | |||
| pub const MENU_Y_BASE_OFFSET: i16 = 28; | |||
| pub const MENU_LINE_SPACING: i16 = 7; | |||
There was a problem hiding this comment.
These constants probably don't need to be pub
There was a problem hiding this comment.
The constants are currently used in the button height computation:
https://github.com/trezor/trezor-firmware/pull/4617/files#diff-1b1facc68c7698bce35416442b579679cca897196b1ccc141decaa5799390c81R117
There was a problem hiding this comment.
Let's do the Button::height() implementation then, as discussed today.
core/embed/rust/src/ui/layout_eckhart/component/vertical_menu_screen.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/layout_eckhart/component/vertical_menu_screen.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/layout_eckhart/component/vertical_menu_screen.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
MenuItemwith title and optional subtitle