Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry estimatefee with more blocks when getting negative value #1153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: retry estimatefee with more blocks when getting negative value #1153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions server/public.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ const txsInAPI = 1000

const secondaryCoinCookieName = "secondary_coin"

const maxEstimateFeeRetries = 3

const (
_ = iota
apiV1
Expand Down Expand Up @@ -1642,6 +1644,25 @@ type resultEstimateFeeAsString struct {
Result string `json:"result"`
}

// estimateFeeRetryNegative tries to estimate the fee X times if the fee is negative.
// It gradually increases the number of blocks to estimate the fee for.
func (s *PublicServer) estimateFeeRetryNegative(blocks int, conservative bool, maxRetries int) (big.Int, error) {
var fee big.Int
var err error
for i := 0; i < maxRetries; i++ {
fee, err = s.chain.EstimateSmartFee(blocks, conservative)
if err == nil && fee.Sign() != -1 {
return fee, nil
}
fee, err = s.chain.EstimateFee(blocks)
if err == nil && fee.Sign() != -1 {
return fee, nil
}
blocks++
}
return big.Int{}, fmt.Errorf("failed to estimate fee after %d retries", maxRetries)
}

func (s *PublicServer) apiEstimateFee(r *http.Request, apiVersion int) (interface{}, error) {
var res resultEstimateFeeAsString
s.metrics.ExplorerViews.With(common.Labels{"action": "api-estimatefee"}).Inc()
Expand All @@ -1660,13 +1681,9 @@ func (s *PublicServer) apiEstimateFee(r *http.Request, apiVersion int) (interfac
return nil, api.NewAPIError("Parameter 'conservative' cannot be converted to boolean", true)
}
}
var fee big.Int
fee, err = s.chain.EstimateSmartFee(blocks, conservative)
fee, err := s.estimateFeeRetryNegative(blocks, conservative, maxEstimateFeeRetries)
if err != nil {
fee, err = s.chain.EstimateFee(blocks)
if err != nil {
return nil, err
}
return nil, api.NewAPIError(fmt.Sprintf("Failed to estimate fee: %v", err), true)
}
res.Result = s.chainParser.AmountToDecimalString(&fee)
return res, nil
Expand Down