Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent line 1 indicator sometimes displaying too high in linum-mode #22

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

trevorpogue
Copy link
Owner

Fixes an issue first mentioned here in #17 .

  • With linum-mode enabled, the line 1 indicator in the left margin would sometimes show too high up, above the actual line 1. The issue would occur when scrolling and topspace-height was zero before scrolling but greater than zero after scrolling. This prevents the issue.

Checklist

  • I have read the topspace contributing guidelines
  • I have added tests (if possible) to cover my change(s)
  • My changes follow the Emacs Lisp conventions and the Emacs Lisp Style Guide
  • I've used the latest version of package-lint to check for packaging issues, and addressed its feedback
  • The new code is not generating bytecode warnings
  • I've updated the readme (if adding/changing user-visible functionality)
  • I have confirmed some of these without doing them (this box shouldn't be marked)

@trevorpogue trevorpogue merged commit be86d5b into main Aug 3, 2022
@trevorpogue trevorpogue added the bug Something isn't working label Aug 3, 2022
@trevorpogue trevorpogue deleted the linum branch August 4, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant