Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#2693: Fix incorrect links #2694

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Issue#2693: Fix incorrect links #2694

merged 1 commit into from
Nov 26, 2024

Conversation

devskillz47
Copy link
Contributor

@devskillz47 devskillz47 commented Nov 26, 2024

Pull request

Description

Related

  • RFC
  • Related Issues: fixes #000, closed #000
  • Related docs PR

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

@darach
Copy link
Member

darach commented Nov 26, 2024

Following the fix DCO retroactively process from github should resolve the DCO check:

https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md

Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@darach darach enabled auto-merge (rebase) November 26, 2024 14:40
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (5814b7f) to head (59b131a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2694   +/-   ##
=======================================
  Coverage   91.34%   91.35%           
=======================================
  Files         309      309           
  Lines       60380    60380           
=======================================
+ Hits        55156    55158    +2     
+ Misses       5224     5222    -2     
Flag Coverage Δ
e2e-command 11.25% <ø> (ø)
e2e-integration 50.26% <ø> (-0.16%) ⬇️
e2e-unit 12.54% <ø> (ø)
e2etests 52.59% <ø> (-0.16%) ⬇️
tremorapi 14.47% <ø> (ø)
tremorcodec 63.96% <ø> (ø)
tremorcommon 63.04% <ø> (ø)
tremorconnectors 28.75% <ø> (+<0.01%) ⬆️
tremorconnectorsaws 11.22% <ø> (ø)
tremorconnectorsazure 4.67% <ø> (ø)
tremorconnectorsgcp 25.31% <ø> (ø)
tremorconnectorsobjectstorage 0.06% <ø> (ø)
tremorconnectorsotel 12.52% <ø> (ø)
tremorconnectorstesthelpers 68.25% <ø> (ø)
tremorinflux 87.71% <ø> (ø)
tremorinterceptor 55.34% <ø> (ø)
tremorpipeline 31.06% <ø> (ø)
tremorruntime 47.12% <ø> (+<0.01%) ⬆️
tremorscript 54.90% <ø> (ø)
tremorsystem 5.76% <ø> (ø)
tremorvalue 69.55% <ø> (ø)
unittests 89.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5814b7f...59b131a. Read the comment docs.

@darach darach merged commit 3a11b31 into tremor-rs:main Nov 26, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants