Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefixes headers with TD #136

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Prefixes headers with TD #136

merged 3 commits into from
Nov 14, 2024

Conversation

tung-vu-td
Copy link
Contributor

We want prefixes headers with TD to prevent any potential conflict with headers in other libraries. So we will rename the following headers that does not have TD prefix yet:

  • Constants.h -> TDConstants.h
  • Session.h -> TDSession.h
  • NSString+Helpers.h -> NSString+TDHelpers.h

@tung-vu-td tung-vu-td requested a review from a team as a code owner November 12, 2024 09:46
@tung-vu-td tung-vu-td force-pushed the rename-constant-headers branch from 6155bf9 to e4a2d29 Compare November 13, 2024 09:56
Copy link
Contributor

@imnutz imnutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kietdo360 kietdo360 requested a review from a team November 13, 2024 15:52
Copy link

@nmpennypacker nmpennypacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for data exfiltrations

@tung-vu-td tung-vu-td merged commit d420d73 into master Nov 14, 2024
10 checks passed
@tung-vu-td tung-vu-td deleted the rename-constant-headers branch November 14, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants