Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix ConfigEvalEngine.evalObjectRecursive(). #1077

Closed
wants to merge 3 commits into from
Closed

[WIP] Fix ConfigEvalEngine.evalObjectRecursive(). #1077

wants to merge 3 commits into from

Conversation

yoyama
Copy link
Contributor

@yoyama yoyama commented Apr 8, 2019

Please NOT merge yet.
I am still investigating. And hope to check by CI.

If nested, no information provided, failed to substitute the variable.
This is related to #974, #678.

Fix ConfigEvalEngine.evalObjectRecursive().
3c78545 
If nested, no information provided, failed to substitute the variable.
This is related to treasure-data#974, treasure-data#678.
@yoyama yoyama requested a review from muga April 8, 2019 11:25
@muga
Copy link
Member

muga commented Apr 9, 2019

@yoyama This is good improvement 👍What do you think that we can include this bug fix in v0.9? Do you have any concerns?

@yoyama
Copy link
Contributor Author

yoyama commented Apr 9, 2019

@muga Thanks for your pointing out. It is important point.
The compatibility is broken when the workflows use ${...} in nested data structures.
If users provide such as data as argument, it will not work.
But I don't know how often happen such case.

@muga muga changed the title [WIP] Fix ConfigEvalEngine.evalObjectRecursive(). [WIP, NOT MERGE] Fix ConfigEvalEngine.evalObjectRecursive(). Apr 19, 2019
muga
muga approved these changes Apr 19, 2019
View reviewed changes
Copy link
Member

@muga muga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoyama thanks! got your point. let's merge it into 0.10 :-)

@muga muga added this to the v0.10.0 milestone Apr 19, 2019
@muga muga changed the title [WIP, NOT MERGE] Fix ConfigEvalEngine.evalObjectRecursive(). [NOT MERGE] Fix ConfigEvalEngine.evalObjectRecursive(). Apr 19, 2019
@yoyama yoyama added the bug label Apr 22, 2019
@yoyama yoyama changed the title [NOT MERGE] Fix ConfigEvalEngine.evalObjectRecursive(). [WIP] Fix ConfigEvalEngine.evalObjectRecursive(). Jul 11, 2019
@civitaspo civitaspo mentioned this pull request Aug 5, 2020
Open
@yoyama
Copy link
Contributor Author

yoyama commented Dec 7, 2020

It is old and I will close it. I may re-open in the future if needed.

@yoyama yoyama closed this Dec 7, 2020
@yoyama yoyama removed this from the v0.10.0 milestone Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muga muga muga approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoyama @muga