-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doesn't work with tab groups #16
Comments
There is a bug (#12 and #13) that in order to fix it requires rewriting this add-on almost from the beginning. And I've spent several hours reading Firefox source code trying to understand how Tab Groups work. And I understood that a huge work has to be done to implement Tab Groups support in this add-on. Therefore it's not rational to implement Tab Groups support in this add-on and after that one more time in the new add-on. All major missing features that require a lot of time to implement (collapsible subtrees, enhanced tab search and Tab Group support) are going to be added in this new add-on. That's my plans for now. |
It is sad it doesnt planning to suppot tab groups, I just tried tab tree it and it looks great. What a pity that I have to remove it only in that case. Is it really that hard to build a tree only based on tabs that currently active on selected group instead of building it on the whole tabs list? |
Btw I didnt know that firefox added tab groups support, need to check it out. Im using this plugin for groups https://addons.mozilla.org/en-us/firefox/addon/tab-groups-helper/?src=ss |
Tab Groups Helper looks much better to me then the native tab groups. |
That is true, some bugs appears due to groups using, it needs to be checked why did it happens. Maybe tab indexes were changed or whatever else, I'm not a kind of ff plugins developer, I'm just a java ee developer = cant help ю much with that. |
Since tab groups are not supported, maybe a warning should be shown to users on first run? And check if user has tab groups. I believe this happens when tab tree is installed while using tab groups: |
Tab groups are slated to be removed in a future version of Firefox in bug 1221050. Given that, it might not be the best investment of time to add support for this. |
I think Tab Groups will stay even if removed from Firefox, there is a plugin (https://addons.mozilla.org/en-us/firefox/addon/tab-groups-panorama/) which is replacing it. As I said in a different thread, I am using Tree-style-tab in combination with groups and it is a very nice combo. |
I also noticed the incompatibility while testing https://addons.mozilla.org/en-US/firefox/addon/tab-groups-panorama/ with https://addons.mozilla.org/en-US/firefox/addon/tab-groups-helper/ Unfortunately it also does not work with https://addons.mozilla.org/en-US/firefox/addon/tabgroups-manager-revived |
i didn't see any issue regarding this. do you intend to make it work or no?
The text was updated successfully, but these errors were encountered: