Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Customizable keyboard shortcuts #49

Open
mehturt opened this issue Nov 12, 2015 · 11 comments
Open

[Feature] Customizable keyboard shortcuts #49

mehturt opened this issue Nov 12, 2015 · 11 comments

Comments

@mehturt
Copy link

mehturt commented Nov 12, 2015

I read today that Tab Groups (Panorama) is going to be removed from FF so I tried this tab with my Nightly. I see all the tabs on the left, which is good, but a few things don't work:

  1. when typing part of the tab name (URL) in the search box, the tab is found (pink rectangle) but it's not focused - if it's scrolled out, it remains scrolled out of view
  2. clicking on tab does not open this tab, but some other tab instead.. - this makes the extension unusable
    Please let me know if you need more information, I'd love to use this extension.
    Thanks.
    m.
@jtojnar
Copy link

jtojnar commented Nov 12, 2015

If you have multiple tab groups in panorama, the switching won’t work (#16).

@mehturt
Copy link
Author

mehturt commented Nov 12, 2015

Yes I read that Tab Groups does not work with this addon, but I'm missing info on what I need to do to make this addon work? I have multiple tab groups right now, do I need to group all my tabs to one group and then enable this addon?
Thanks.

@jtojnar
Copy link

jtojnar commented Nov 12, 2015

If I recall correctly, I moved my tabs to one group while having the add-on enabled and it worked just fine.

@mehturt
Copy link
Author

mehturt commented Nov 12, 2015

Cool, I'll try that. Thanks.

@traxium
Copy link
Owner

traxium commented Nov 12, 2015

It's good to know Firefox version number. And by default "Tab search jumps to the first match" option is disabled and it just highlights all matching tabs.

@mehturt
Copy link
Author

mehturt commented Nov 12, 2015

The version may change every day, currently it's 45.0a1
https://nightly.mozilla.org/

@mehturt
Copy link
Author

mehturt commented Nov 13, 2015

In my other profile, where I did not have tab groups, it works as expected. This issue can now be closed.
Btw. is there a keybinding to focus the search bar?

@traxium
Copy link
Owner

traxium commented Nov 14, 2015

Ctrl+Alt+Shift+F focuses the search bar or if it's hidden brings it up and focuses.

@mehturt
Copy link
Author

mehturt commented Nov 16, 2015

ah, that's too complex. is there a way to assign keybinding?

@traxium
Copy link
Owner

traxium commented Nov 16, 2015

Not yet.

@roryokane
Copy link
Contributor

roryokane commented Oct 21, 2016

My comment in #144 may help with implementing this. It points out where key combinations are currently hard-coded except for the configurable F8 shortcut, and it describes two possible ways to load key combination descriptions from saved preferences so that you can check whether that key combination has just been pressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants