Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt #141

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fmt #141

wants to merge 3 commits into from

Conversation

fcooper8472
Copy link
Collaborator

@martinjrobins just playing around with {fmt}. Not suggesting we should use it, but wanted an excuse to have a go with it.

It seems very nice! And you can put {} injections inside raw string literals which is very nice for writing svg elements that otherwise need escaped " characters. Has nice clean float precision options, too.

The fmt::format matches std::format that was introduced in C++20.

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #141 into master will decrease coverage by 27.10%.
The diff coverage is 26.51%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #141       +/-   ##
===========================================
- Coverage   87.85%   60.75%   -27.11%     
===========================================
  Files          48       52        +4     
  Lines        2199     4079     +1880     
===========================================
+ Hits         1932     2478      +546     
- Misses        267     1601     +1334     
Impacted Files Coverage Δ
src/fmt/format.cc 0.00% <0.00%> (ø)
src/fmt/format.h 31.65% <ø> (ø)
src/fmt/format-inl.h 20.68% <20.68%> (ø)
src/fmt/core.h 49.28% <49.28%> (ø)
src/backend/BackendSVG.cpp 74.16% <80.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 607404c...07281cb. Read the comment docs.

@martinjrobins
Copy link
Collaborator

that does look really nice! I'd be happy to start using this, but would require a bit of work upfront to convert everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants