Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove totalSupply. Add checked balance arithmetic. #397

Closed
wants to merge 1 commit into from
Closed

Remove totalSupply. Add checked balance arithmetic. #397

wants to merge 1 commit into from

Conversation

jtriley2p
Copy link
Contributor

Description

Removes totalSupply in accordance with EIP-6909 update.

Adds checked arithmetic on balance increases, as they previously relied on a checked addition to totalSupply

Note: npm run lint corrects src/test/CREATE3.t.sol. Disregarding for simplicity.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge snapshot?
  • Ran npm run lint?
  • Ran forge test?

@jtriley2p
Copy link
Contributor Author

something's up with the ci, forge snapshot --check is failing, even on solmate main

gonna halt this for now and open a pr for a fix

@jtriley2p jtriley2p marked this pull request as draft November 22, 2023 10:46
@jtriley2p jtriley2p closed this by deleting the head repository Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jtriley2p