Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live Bus Data Beta Release #963

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Live Bus Data Beta Release #963

merged 2 commits into from
Apr 3, 2024

Conversation

devinmatte
Copy link
Member

Motivation

Release gobble bus data to the masses!

Changes

Releases day of bus data and switches bus to use the same date presets as rapid transit

Screenshot 2024-03-28 at 7 25 48 PM

Testing Instructions

Confirm that there is live data for all bus routes

Confirm that data before Feb 29th 2024 doesn't show the beta warning

Confirm that aggregates and single dates all still work for bus data

@github-actions github-actions bot added backend Change to backend code frontend Change to frontend code labels Mar 28, 2024
Comment on lines 36 to 58
Data shown here is collected by TransitMatters using the{' '}
<Link
href="https://www.mbta.com/developers/v3-api/streaming"
rel="noopener noreferrer"
target="_blank"
className={classNames(lineColorTextHover[line ?? 'DEFAULT'])}
>
MBTA's streaming API
</Link>
. Unlike other data sources we show, this data is not cleaned or filtered in any way
before display. Innacuracies may be present.
</p>
<p>
Official MBTA data will be shown when available. Technical details of our data
collection can be found{' '}
<Link
href="https://github.com/transitmatters/gobble"
rel="noopener noreferrer"
target="_blank"
className={classNames(lineColorTextHover[line ?? 'DEFAULT'])}
>
here
</Link>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph could be better: it has some typos & passive voice. And because the gobble README has no English documentation, the GitHub link isn't super useful for the general public :(

How about this?

Suggested change
Data shown here is collected by TransitMatters using the{' '}
<Link
href="https://www.mbta.com/developers/v3-api/streaming"
rel="noopener noreferrer"
target="_blank"
className={classNames(lineColorTextHover[line ?? 'DEFAULT'])}
>
MBTA's streaming API
</Link>
. Unlike other data sources we show, this data is not cleaned or filtered in any way
before display. Innacuracies may be present.
</p>
<p>
Official MBTA data will be shown when available. Technical details of our data
collection can be found{' '}
<Link
href="https://github.com/transitmatters/gobble"
rel="noopener noreferrer"
target="_blank"
className={classNames(lineColorTextHover[line ?? 'DEFAULT'])}
>
here
</Link>
We collect real-time bus data using the{' '}
<Link
href="https://www.mbta.com/developers/v3-api/streaming"
rel="noopener noreferrer"
target="_blank"
className={classNames(lineColorTextHover[line ?? 'DEFAULT'])}
>
MBTA's V3 API
</Link>
. Please expect reduced accuracy, as this data is not preprocessed.
</p>
<p>
We favor official performance data from the MBTA when it's available. Please
<Link
href="https://transitmatters.org/transitmatters-labs"
rel="noopener noreferrer"
target="_blank"
className={classNames(lineColorTextHover[line ?? 'DEFAULT'])}
>
contact us
</Link>
for technical details.

Copy link
Contributor

@mathcolo mathcolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But honestly besides that ^, do it!

@devinmatte devinmatte merged commit afc0ec8 into main Apr 3, 2024
4 checks passed
@devinmatte devinmatte deleted the day-of-bus-beta branch April 3, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Change to backend code frontend Change to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants