Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(yankee): Permission stuff, and allow for starting with no bus positions #84

Merged
merged 2 commits into from
Mar 26, 2024
Merged

fix(yankee): Permission stuff, and allow for starting with no bus positions #84

merged 2 commits into from
Mar 26, 2024

Conversation

rudiejd
Copy link
Contributor

@rudiejd rudiejd commented Mar 26, 2024 •
edited
Loading

The lambda wasn't starting without my seeding it with bunk bus positions. Additionally, it needs permission to access the tm-gtfs bucket.

@rudiejd rudiejd requested a review from austinjpaul as a code owner March 26, 2024 03:40
@rudiejd rudiejd changed the title fix(yankee): Permission stuff fix(yankee): Permission stuff, and allow for starting with no bus positions Mar 26, 2024
devinmatte
devinmatte requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@devinmatte devinmatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you not use wildcards ideally?

@rudiejd rudiejd merged commit cb07a3b into transitmatters:main Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinmatte devinmatte devinmatte approved these changes

@austinjpaul austinjpaul Awaiting requested review from austinjpaul austinjpaul is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudiejd @devinmatte