-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B-22368-INT add closeout counselor label to move history #14750
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…counselor in move history
ryan-mchugh
approved these changes
Feb 5, 2025
NOTE - story needs AC |
Added - thanks |
pambecker
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
Summary
In lieu of making a bunch of complicated sql changes in
move_history_fetcher.sql
to add ppm_shipments.status to the context, I thought this approach would be better/easier. Since the counseling queue is populated by moves with a status of NEEDS_SERVICES_COUNSELING, and, once they leave they queue that move can NEVER RETURN, I surmised that if a counselor is being assigned to a move that does NOT have the NEEDS_SERVICES_COUNSELING status, they must be a closeout counselor.To test