Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-22368-INT add closeout counselor label to move history #14750

Merged
merged 11 commits into from
Feb 11, 2025

Conversation

paulstonebraker
Copy link
Contributor

Agility ticket

Summary

In lieu of making a bunch of complicated sql changes in move_history_fetcher.sql to add ppm_shipments.status to the context, I thought this approach would be better/easier. Since the counseling queue is populated by moves with a status of NEEDS_SERVICES_COUNSELING, and, once they leave they queue that move can NEVER RETURN, I surmised that if a counselor is being assigned to a move that does NOT have the NEEDS_SERVICES_COUNSELING status, they must be a closeout counselor.

To test

  1. Make a move with a PPM
  2. As a supervisor SC, assign someone. Assign someone else. Unassign. Assign yourself.
  3. Check the move history and confirm all the labels are good
  4. Get the move advanced to where a customer can submit their PPM documents
  5. Submit PPM documents as customer
  6. As closeout counselor, assign someone. Assign someone else. Unassign. Assign yourself.
  7. Check the move history and confirm all the labels are good

@paulstonebraker paulstonebraker marked this pull request as ready for review February 5, 2025 20:09
@paulstonebraker paulstonebraker requested review from a team as code owners February 5, 2025 20:09
@paulstonebraker paulstonebraker self-assigned this Feb 5, 2025
@paulstonebraker paulstonebraker added G-Unit Scrum Team G INTEGRATION Slated for Integration Testing labels Feb 5, 2025
@ryan-mchugh
Copy link
Contributor

Local Testing
image
image

@ryan-mchugh
Copy link
Contributor

NOTE - story needs AC

@paulstonebraker
Copy link
Contributor Author

NOTE - story needs AC

Added - thanks

@paulstonebraker paulstonebraker merged commit 69d255d into integrationTesting Feb 11, 2025
5 of 6 checks passed
@paulstonebraker paulstonebraker deleted the B-22368-INT branch February 11, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
G-Unit Scrum Team G INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

3 participants