Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B 21983 MAIN - Display Counseling Office in Move Details (Review After B-21977) #14736

Draft
wants to merge 46 commits into
base: main
Choose a base branch
from
Draft

B 21983 MAIN - Display Counseling Office in Move Details (Review After B-21977) #14736

wants to merge 46 commits into from
+1,661 −90

Conversation

ajlusk
Copy link
Contributor

@ajlusk ajlusk commented Feb 4, 2025 •
edited
Loading

B-21983

INT PR

Summary

Includes changes from B-21977

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Access the office app as a services counselor
  2. Open or create a move that has a populated counseling office (most of the seed data doesn't)
  3. Verify the counseling office is displayed in the orders card.
  4. Repeat with a TOO and/or TIO as they use a different move details component.

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

ajlusk added 30 commits December 18, 2024 00:04
@ajlusk
21977 functioning - Services counselor can select counseling office w…
09d3cfa 
…hen creating a move
@ajlusk
tests for 21997
c61301b
@ajlusk
Merge remote-tracking branch 'origin/main' into B-21977
1b14403
@ajlusk
expand 21997 tests
fdb8347
@ajlusk
Merge remote-tracking branch 'origin/main' into B-21983
1dda9fe
@ajlusk
Merge branch 'proxyMiddlewareFix' into B-21983
c4c1438
@ajlusk
removed jest debugs and added no counseling office test case
4c9b0ca
@ajlusk
Added counseling office to move payload
d308a38
@ajlusk
Merge remote-tracking branch 'origin/main' into B-21983
6bce710
@ajlusk
Merge remote-tracking branch 'origin/main' into B-21977
f5b127b
@ajlusk
update counseling office selction instructions
b35066b
@ajlusk
Merge remote-tracking branch 'origin/MAIN-B-22122' into B-21977
591503c
@ajlusk
Merge remote-tracking branch 'origin/main' into B-21977
787e038
@ajlusk
Merge branch 'B-21977' into B-21983
09d855d
@ajlusk
Add counseling office to orders list component
6a76715
@ajlusk
counseling office in orders card test fix
9dfc76c
@ajlusk
Merge remote-tracking branch 'origin/main' into B-21977
b248256
@ajlusk
extend counselor add orders with counseling offices tests
eb0949e
@ajlusk
increase test coverage of counseling offices model to payload per rev…
a013127 
…iew request
@ajlusk
Merge branch 'B-21977' into B-21983
b9cfd42
@ajlusk
Merge remote-tracking branch 'origin/main' into B-21983
8a74e1f
@ajlusk
peer review suggestions
3123707
@ajlusk
Merge remote-tracking branch 'origin/main' into B-21977
c69023e
@ajlusk
fix office user selecting counseling office validation
9254ad2
@ajlusk
fix AddOrdersForm test
224a40b
@ajlusk
Merge remote-tracking branch 'origin/main' into B-21977
eb05df9
@ajlusk
consistent required hints on AddOrdersForm.jsx
cb4cfaa
@ajlusk
test fixes for 21977
cf53cfa
@ajlusk
Merge remote-tracking branch 'origin/main' into B-21977
f704154
@ajlusk
Merge remote-tracking branch 'origin/main' into B-21977
9ad79b6
ajlusk and others added 12 commits January 24, 2025 22:33
@ajlusk ajlusk added Scrummy Bears Scrum Team H MAIN labels Feb 4, 2025
@ajlusk ajlusk self-assigned this Feb 4, 2025
@ajlusk ajlusk changed the title B 21983 MAIN - Display Counseling Office in Orders (After B-21977) B 21983 MAIN - Display Counseling Office in Move Detail (Review After B-21977) Feb 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
314 12.93 MB → 12.93 MB (+1.37 kB) +0.01%
Changeset
File Δ Size
src/components/Office/AddOrdersForm/AddOrdersForm.jsx 📈 +1.52 kB (+13.76%) 11.06 kB → 12.58 kB
src/components/Office/DefinitionLists/OrdersList.jsx 📈 +421 B (+7.33%) 5.61 kB → 6.02 kB
src/services/ghcApi.js 📈 +181 B (+0.78%) 22.59 kB → 22.76 kB
src/pages/Office/MoveDetails/MoveDetails.jsx 📈 +14 B (+0.05%) 28.19 kB → 28.21 kB
src/pages/Office/ServicesCounselingMoveDetails/ServicesCounselingMoveDetails.jsx 📈 +14 B (+0.04%) 32.5 kB → 32.51 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
static/js/main.e6782599.js 0 B → 790.95 kB (+790.95 kB) -
static/js/3786.fd5cd469.chunk.js 0 B → 45.33 kB (+45.33 kB) -
static/js/1865.13c0041a.chunk.js 0 B → 37.11 kB (+37.11 kB) -
static/js/6074.29353022.chunk.js 0 B → 28.22 kB (+28.22 kB) -
static/js/1204.4a08c391.chunk.js 0 B → 24.9 kB (+24.9 kB) -
static/js/7585.868b826f.chunk.js 0 B → 21.33 kB (+21.33 kB) -

Removed

Asset File Size % Changed
static/js/main.88e819ac.js 790.95 kB → 0 B (-790.95 kB) -100%
static/js/3786.59e33d84.chunk.js 45.2 kB → 0 B (-45.2 kB) -100%
static/js/1865.ebeded33.chunk.js 37.09 kB → 0 B (-37.09 kB) -100%
static/js/6074.2818930a.chunk.js 27.27 kB → 0 B (-27.27 kB) -100%
static/js/1204.545de8fd.chunk.js 24.89 kB → 0 B (-24.89 kB) -100%
static/js/7585.59df9caf.chunk.js 21.06 kB → 0 B (-21.06 kB) -100%

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/7432.6e5d3b9c.chunk.js 890 kB 0%
static/js/4282.d860b40a.chunk.js 721.12 kB 0%
static/css/2392.7a7a060b.chunk.css 689.34 kB 0%
static/css/1810.f6cd0aa5.chunk.css 665.04 kB 0%
static/css/885.04767869.chunk.css 664.61 kB 0%
static/media/hero.bf01157b9686e90e34dd.png 609.24 kB 0%
static/css/7159.fa13a92b.chunk.css 499.62 kB 0%
static/css/8810.90d403c8.chunk.css 455.56 kB 0%
static/css/3710.4b263fe0.chunk.css 454.23 kB 0%
static/css/3786.ed106157.chunk.css 423.15 kB 0%
static/js/2548.c31aa081.chunk.js 334.66 kB 0%
static/js/7159.354ea92e.chunk.js 283.67 kB 0%
static/js/2271.af4d7477.chunk.js 154.5 kB 0%
static/js/5845.ba302a06.chunk.js 113.33 kB 0%
static/js/1978.49aa924b.chunk.js 108.09 kB 0%
static/media/PublicSans-Regular.af5c059f36e21e13f39f.ttf 78.03 kB 0%
static/media/PublicSans-Light.839012ec5b7d44a46954.ttf 77.91 kB 0%
static/media/PublicSans-Italic.642113a6a2f365350349.ttf 77.7 kB 0%
static/media/PublicSans-Bold.a52885b904d32280b208.ttf 77.61 kB 0%
static/media/PublicSans-LightItalic.49a5ea322c6c3762b921.ttf 77.44 kB 0%
static/media/PublicSans-BoldItalic.cbc51dd94deab4465d42.ttf 77.41 kB 0%
static/js/1482.689ee974.chunk.js 74.03 kB 0%
static/js/6085.491a4a4f.chunk.js 66.55 kB 0%
static/media/transcom-emblem.bcb580b55633c358c82d89f4798081c5.svg 65.22 kB 0%
static/js/6854.8ac4d3c6.chunk.js 63.31 kB 0%
static/js/3502.5c1d6e28.chunk.js 60.3 kB 0%
static/js/4267.dafdbe6c.chunk.js 59.78 kB 0%
static/js/4690.1d8fce21.chunk.js 59.09 kB 0%
static/js/751.e3299ba1.chunk.js 58.25 kB 0%
static/media/sourcesanspro-light-webfont.d6f73cf7210d3b5c2fa9.ttf 53.23 kB 0%
static/media/sourcesanspro-regular-webfont.5acfe0d0f69444765ba4.ttf 53.16 kB 0%
static/media/sourcesanspro-bold-webfont.9a76932911f04be25044.ttf 53.07 kB 0%
static/js/5588.cf16a060.chunk.js 52.76 kB 0%
static/js/3083.47355b7b.chunk.js 51.25 kB 0%
static/js/7525.a50a65a3.chunk.js 50.19 kB 0%
static/js/6155.ccd567a8.chunk.js 49.45 kB 0%
static/css/1978.cf0bdb54.chunk.css 48.88 kB 0%
static/media/Latin-Merriweather-Regular.43dc3080728216519bf0.ttf 48.32 kB 0%
static/media/Latin-Merriweather-Light.30dd683b4fcfe95b030b.ttf 48.01 kB 0%
static/js/992.bb9e88fd.chunk.js 46.69 kB 0%
static/media/Latin-Merriweather-Bold.b87366633b1019e8c63c.ttf 46.12 kB 0%
static/js/1661.6014bf94.chunk.js 43.67 kB 0%
asset-manifest.json 42.3 kB 0%
static/js/6351.909fa525.chunk.js 42.16 kB 0%
static/js/5811.5a51ce90.chunk.js 42.11 kB 0%
static/js/5165.a739b1d0.chunk.js 40.18 kB 0%
static/js/447.e1921258.chunk.js 40.04 kB 0%
static/media/PublicSans-BoldItalic.6bb0cb126756efec5fa5.woff 39.72 kB 0%
static/media/PublicSans-Italic.333d9a80b7b3b003b3c5.woff 39.57 kB 0%
static/media/PublicSans-LightItalic.4c86a8eb158c949923dd.woff 39.53 kB 0%
static/media/Latin-Merriweather-BoldItalic.4d74f3bda45f5aba1abf.ttf 39.52 kB 0%
static/media/PublicSans-Light.8460a3397f2ffc7d22d0.woff 39.23 kB 0%
static/media/PublicSans-Regular.f32753567f64c1ddeec8.woff 39.17 kB 0%
static/media/PublicSans-Bold.8c3655e2b925bcad90cd.woff 39.11 kB 0%
static/media/Latin-Merriweather-Italic.b60043e65fa5cbcedb80.ttf 38.55 kB 0%
static/media/Latin-Merriweather-LightItalic.26ebdd3b8f1d039bc3dd.ttf 38.53 kB 0%
static/media/sourcesanspro-lightitalic-webfont.43ea3d39e6aa59fb6f1b.ttf 38.23 kB 0%
static/media/sourcesanspro-italic-webfont.3efee318468995ac04af.ttf 37.94 kB 0%
static/media/sourcesanspro-bolditalic-webfont.af3dd40e0ac8e2ca50ac.ttf 37.85 kB 0%
static/js/8501.1c853962.chunk.js 37.62 kB 0%
static/js/3530.7aae8676.chunk.js 35.12 kB 0%
static/js/1450.674d183e.chunk.js 34.99 kB 0%
static/js/3898.caa02a0b.chunk.js 34.65 kB 0%
static/media/PublicSans-BoldItalic.effa83ee2a557ae8a57e.woff2 32.43 kB 0%
static/media/PublicSans-Italic.8be0a159b540a60fd93a.woff2 32.26 kB 0%
static/media/PublicSans-LightItalic.475db532b9392ec581c5.woff2 32.14 kB 0%
static/media/PublicSans-Light.4ba4759c3e98938156d7.woff2 31.84 kB 0%
static/media/roboto-mono-v5-latin-300italic.93511dbad22ceb584f03.ttf 31.83 kB 0%
static/media/roboto-mono-v5-latin-700italic.da78bf0b1b435f40ca19.ttf 31.8 kB 0%
static/media/PublicSans-Regular.e86d2642f412b9493b14.woff2 31.79 kB 0%
static/media/PublicSans-Bold.4045385082dfc34c22d7.woff2 31.64 kB 0%
static/media/roboto-mono-v5-latin-italic.4863add4d566a55b6a97.ttf 31.58 kB 0%
static/js/6748.524cd56c.chunk.js 31.49 kB 0%
static/media/roboto-mono-v5-latin-300.ce3838471d62f8364e12.ttf 31.41 kB 0%
static/media/okta_logo.56ac9bdcdffeda24c715.png 31.3 kB 0%
static/media/roboto-mono-v5-latin-700.e57caf7ea634a258a9b2.ttf 30.36 kB 0%
static/media/roboto-mono-v5-latin-regular.215adb34128fcb20668b.ttf 30.32 kB 0%
static/js/9706.12b8345e.chunk.js 30.21 kB 0%
static/js/7340.ad91933d.chunk.js 30.05 kB 0%
static/css/992.e40d7f04.chunk.css 29.15 kB 0%
static/css/6351.2d11624e.chunk.css 28.34 kB 0%
static/css/3898.9b4260c6.chunk.css 27.94 kB 0%
static/media/Latin-Merriweather-Regular.add503b41601df15b97e.woff 26.87 kB 0%
static/media/Latin-Merriweather-Light.7b2a6350fcb212efe521.woff 26.36 kB 0%
static/media/Latin-Merriweather-Bold.b6cbc321678701d773c6.woff 26.26 kB 0%
static/css/1865.b6baac32.chunk.css 25.9 kB 0%
static/media/sourcesanspro-regular-webfont.c4e25ab10baa365dfc66.woff 25.53 kB 0%
static/media/sourcesanspro-bold-webfont.e7e051e1bc64fa899317.woff 25.43 kB 0%
static/media/sourcesanspro-light-webfont.70e7d719e258c9a7e68b.woff 25.35 kB 0%
static/css/1482.e3f92bbd.chunk.css 25.31 kB 0%
static/js/1810.ca78a922.chunk.js 24.84 kB 0%
static/js/2923.5ae1fb30.chunk.js 24.52 kB 0%
static/js/7979.d44075bd.chunk.js 24.43 kB 0%
static/media/Latin-Merriweather-BoldItalic.a0bcf832ed51501c237c.woff 23.89 kB 0%
static/media/Latin-Merriweather-Italic.80d8a9aff0d8bdeb966d.woff 23.59 kB 0%
static/media/Latin-Merriweather-LightItalic.8a239a410a47b6192e05.woff 23.25 kB 0%
static/js/9368.2210d67e.chunk.js 22.89 kB 0%
static/css/9706.25885e5b.chunk.css 22.35 kB 0%
static/js/5780.0095ccd0.chunk.js 21.35 kB 0%
static/media/Latin-Merriweather-Regular.a30c1b8fcb759e9fe728.woff2 21.18 kB 0%
static/media/Latin-Merriweather-Bold.9caa42f21e4ae090b755.woff2 20.81 kB 0%
static/media/Latin-Merriweather-Light.f347d9834a5feacbcefb.woff2 20.76 kB 0%
static/media/roboto-mono-v5-latin-700italic.0a6791447401e0ebd70d.woff 20.64 kB 0%
static/media/roboto-mono-v5-latin-italic.756750acefdb77704c08.woff 20.6 kB 0%
static/js/4216.4350b0df.chunk.js 20.58 kB 0%
static/media/roboto-mono-v5-latin-300italic.1b8d46dae0a077f999ae.woff 20.56 kB 0%
static/js/8471.87cc5a3a.chunk.js 20.42 kB 0%
static/css/2271.643cfb33.chunk.css 20.08 kB 0%
static/css/8778.c8e51c91.chunk.css 20.07 kB 0%
static/media/sourcesanspro-regular-webfont.e7bccfa631a0017f31da.woff2 20.06 kB 0%
static/media/sourcesanspro-light-webfont.e5f1a42e1c2b97e25876.woff2 19.93 kB 0%
static/media/sourcesanspro-bold-webfont.4a1efbe82eaa84ff89ed.woff2 19.89 kB 0%
static/js/6884.b9267f82.chunk.js 19.8 kB 0%
static/media/sourcesanspro-lightitalic-webfont.455d120362f79aa219d4.woff 19.78 kB 0%
static/media/sourcesanspro-italic-webfont.0aaeabbaba3845331078.woff 19.73 kB 0%
static/media/sourcesanspro-bolditalic-webfont.73021f1aabd43f50e16a.woff 19.69 kB 0%
static/media/roboto-mono-v5-latin-300.92dd8f0ccfaebc33f817.woff 19.42 kB 0%
static/css/8120.db072867.chunk.css 19.32 kB 0%
static/media/roboto-mono-v5-latin-regular.a3246d29b40a8b0da142.woff 19.12 kB 0%
static/media/Latin-Merriweather-BoldItalic.dc8b76b44a8a6e5fad1c.woff2 19.11 kB 0%
static/media/roboto-mono-v5-latin-700.d85b43c39f4620dfa5b4.woff 19.11 kB 0%
static/js/9875.07b87104.chunk.js 18.96 kB 0%
static/js/862.85621938.chunk.js 18.86 kB 0%
static/media/Latin-Merriweather-Italic.c63d4066b0f133fc519f.woff2 18.8 kB 0%
static/js/1775.2ce0528d.chunk.js 18.8 kB 0%
static/media/Latin-Merriweather-LightItalic.506121dad559538d44ed.woff2 18.53 kB 0%
static/js/8120.ea792570.chunk.js 18.49 kB 0%
static/media/smart-card.c810117aa96a9adbd31b.png 18.39 kB 0%
static/js/9740.2313e1fe.chunk.js 18.37 kB 0%
static/js/6917.da572d04.chunk.js 17.78 kB 0%
static/css/3083.49432158.chunk.css 17.71 kB 0%
static/js/2392.9d6f616b.chunk.js 17.71 kB 0%
static/media/roboto-mono-v5-latin-300italic.09cc62a8fbd32c8b2812.woff2 16.93 kB 0%
static/media/roboto-mono-v5-latin-700italic.5a8f743549cc6cef9a00.woff2 16.93 kB 0%
static/media/sad-computer.b62f031230f84d7db1b1.png 16.92 kB 0%
static/js/8554.850a198d.chunk.js 16.91 kB 0%
static/media/roboto-mono-v5-latin-italic.087069a9f454e2581ed6.woff2 16.91 kB 0%
static/js/4417.acd664e6.chunk.js 16.57 kB 0%
static/js/9336.e59e6f6d.chunk.js 16.41 kB 0%
static/media/sourcesanspro-bolditalic-webfont.ef69f0d737406260319a.woff2 16.03 kB 0%
static/media/roboto-mono-v5-latin-300.316b1352cc4ab2054de6.woff2 16 kB 0%
static/media/sourcesanspro-italic-webfont.c6c9fd228e87eefaf1d4.woff2 15.99 kB 0%
static/js/4573.0f7bd500.chunk.js 15.98 kB 0%
static/media/sourcesanspro-lightitalic-webfont.9c5bf2190b2471c2f22b.woff2 15.93 kB 0%
static/js/8693.b4171601.chunk.js 15.91 kB 0%
static/media/roboto-mono-v5-latin-regular.f1dc10a756c2c544588b.woff2 15.65 kB 0%
static/media/roboto-mono-v5-latin-700.936869ba46988c238748.woff2 15.58 kB 0%
static/js/2680.671f7ff2.chunk.js 15.46 kB 0%
static/js/476.295779cf.chunk.js 15.16 kB 0%
static/js/6536.62897ba9.chunk.js 14.92 kB 0%
static/js/6411.bb78f854.chunk.js 14.59 kB 0%
static/js/6696.0737c7e0.chunk.js 14.3 kB 0%
static/css/4295.16754ba3.chunk.css 14.2 kB 0%
static/css/6676.16754ba3.chunk.css 14.2 kB 0%
static/css/1204.68535fbe.chunk.css 14.19 kB 0%
static/js/9463.011c392e.chunk.js 14.13 kB 0%
static/js/1465.35289a0b.chunk.js 14.02 kB 0%
static/css/7340.99f19287.chunk.css 13.73 kB 0%
static/css/7979.8fdc7e53.chunk.css 13.66 kB 0%
static/js/8778.85974ca2.chunk.js 13.35 kB 0%
static/js/9735.21109ea5.chunk.js 13.33 kB 0%
static/css/6884.03b59c60.chunk.css 13.21 kB 0%
static/js/7104.96ee1a6a.chunk.js 12.79 kB 0%
static/css/1661.ac503a10.chunk.css 12.74 kB 0%
static/css/6155.ac503a10.chunk.css 12.74 kB 0%
static/css/896.9b31dccf.chunk.css 12.53 kB 0%
static/css/6955.0d6f6918.chunk.css 12.49 kB 0%
static/css/9336.0d6f6918.chunk.css 12.49 kB 0%
static/css/8554.ceb7ec01.chunk.css 12.38 kB 0%
static/css/8501.9490d7a2.chunk.css 12.25 kB 0%
static/js/946.3f94defc.chunk.js 12.05 kB 0%
static/css/2512.49857b11.chunk.css 11.92 kB 0%
static/js/9414.695aa91c.chunk.js 11.81 kB 0%
static/js/9284.a7f5f949.chunk.js 11.8 kB 0%
static/js/3665.5614cae8.chunk.js 11.7 kB 0%
static/js/8797.ed6f2421.chunk.js 11.13 kB 0%
static/js/8960.7a3fb464.chunk.js 10.96 kB 0%
static/js/2195.eba228e6.chunk.js 10.88 kB 0%
static/js/871.0ef10e5b.chunk.js 10.54 kB 0%
static/js/5091.7c4f6ef7.chunk.js 10.42 kB 0%
static/js/5426.4fcc54c9.chunk.js 10.16 kB 0%
static/css/3530.8175226c.chunk.css 10.06 kB 0%
static/js/8167.e16f5bf9.chunk.js 10.05 kB 0%
static/js/1517.2f39cf46.chunk.js 10 kB 0%
static/js/5560.40da3323.chunk.js 9.97 kB 0%
static/js/9739.bb3c92d9.chunk.js 9.88 kB 0%
static/js/8753.de89385e.chunk.js 9.85 kB 0%
static/js/2823.07bdbc2f.chunk.js 9.82 kB 0%
static/js/7612.47ba4519.chunk.js 9.74 kB 0%
static/js/6462.21d5c9b4.chunk.js 9.44 kB 0%
static/css/4417.2fa5e788.chunk.css 9.39 kB 0%
static/js/4098.40ebe278.chunk.js 9.27 kB 0%
static/css/4267.15569048.chunk.css 9.26 kB 0%
static/js/1761.906a4ef7.chunk.js 9.06 kB 0%
static/js/6955.66aa2fef.chunk.js 8.88 kB 0%
static/js/6368.c980b40a.chunk.js 8.8 kB 0%
static/css/9735.afc2ee27.chunk.css 8.72 kB 0%
static/css/4662.f471fc45.chunk.css 8.59 kB 0%
static/css/7104.4f0dc616.chunk.css 8.42 kB 0%
static/css/1775.32d3e4ad.chunk.css 8.3 kB 0%
static/css/9284.e62705b2.chunk.css 8.22 kB 0%
static/css/5811.354737e1.chunk.css 8.08 kB 0%
static/css/1761.9509256a.chunk.css 7.94 kB 0%
static/js/4723.36b0bb3a.chunk.js 7.92 kB 0%
static/css/1465.2d1e68a7.chunk.css 7.92 kB 0%
static/css/3665.7e57832d.chunk.css 7.66 kB 0%
static/css/743.cd4069af.chunk.css 7.65 kB 0%
static/css/6265.031deaa6.chunk.css 7.63 kB 0%
static/css/6293.031deaa6.chunk.css 7.63 kB 0%
static/js/4828.474d2798.chunk.js 7.62 kB 0%
static/js/896.a7cec3fb.chunk.js 7.55 kB 0%
static/css/4573.f692cd9d.chunk.css 7.42 kB 0%
static/js/396.8b3af17a.chunk.js 7.24 kB 0%
static/js/885.1909eecd.chunk.js 7.06 kB 0%
static/js/4246.5ff7fa26.chunk.js 6.95 kB 0%
static/js/8552.2d441ac2.chunk.js 6.65 kB 0%
static/css/6462.131dcdd9.chunk.css 6.53 kB 0%
static/js/5280.a7c12270.chunk.js 5.91 kB 0%
static/css/8753.b51f505b.chunk.css 5.44 kB 0%
static/media/milmove-logo.c977261e059ba42b2b70ba95cfb3d3de.svg 5.4 kB 0%
static/js/6265.5ddcec42.chunk.js 4.92 kB 0%
static/css/1617.61b4e3b3.chunk.css 4.84 kB 0%
static/js/2283.cfcf4197.chunk.js 4.74 kB 0%
static/css/5560.f8caa9b0.chunk.css 4.67 kB 0%
static/js/177.ba46bdbc.chunk.js 4.57 kB 0%
static/js/4772.8e680e13.chunk.js 4.49 kB 0%
static/css/6368.bbc00861.chunk.css 4.4 kB 0%
static/js/1224.0e72db8a.chunk.js 4.11 kB 0%
static/css/7612.7f6e106e.chunk.css 3.94 kB 0%
static/css/2823.3dd5d616.chunk.css 3.8 kB 0%
static/css/9739.3dd5d616.chunk.css 3.8 kB 0%
static/js/6293.b9a8dd76.chunk.js 3.78 kB 0%
static/css/8167.d2583119.chunk.css 3.73 kB 0%
static/css/4098.d44bdc14.chunk.css 3.68 kB 0%
static/js/743.faea0655.chunk.js 3.39 kB 0%
static/js/4081.67c244f2.chunk.js 3.3 kB 0%
static/css/5426.c785fdaf.chunk.css 3.27 kB 0%
static/css/2680.26e049de.chunk.css 3.25 kB 0%
static/js/9282.3fb7e31c.chunk.js 3.2 kB 0%
static/js/1711.921429ec.chunk.js 2.93 kB 0%
static/js/8656.45d7677d.chunk.js 2.89 kB 0%
static/css/4246.af28e9df.chunk.css 2.8 kB 0%
static/css/9414.1e52fa0b.chunk.css 2.77 kB 0%
static/css/396.b442cb05.chunk.css 2.65 kB 0%
static/css/5091.652fa3fa.chunk.css 2.49 kB 0%
static/js/7713.854e2e94.chunk.js 2.36 kB 0%
static/js/85.a3317e7d.chunk.js 2.34 kB 0%
static/css/4723.25becf80.chunk.css 2.17 kB 0%
static/css/2178.d45c6948.chunk.css 2.04 kB 0%
static/css/9797.35c45fc7.chunk.css 2.04 kB 0%
static/css/8797.d46112ee.chunk.css 1.99 kB 0%
static/js/4662.ddafe079.chunk.js 1.97 kB 0%
static/css/1224.6facdf3f.chunk.css 1.96 kB 0%
static/css/7713.7b9e081a.chunk.css 1.88 kB 0%
static/css/85.7b9e081a.chunk.css 1.88 kB 0%
static/js/1617.45f791dd.chunk.js 1.88 kB 0%
static/js/2178.df77f988.chunk.js 1.79 kB 0%
static/js/9797.2ccadc05.chunk.js 1.78 kB 0%
static/media/loader.10d2d7c0a681e4e825da.svg 1.67 kB 0%
static/css/main.5749796c.css 1.27 kB 0%
static/js/2512.6c103be9.chunk.js 1.16 kB 0%
static/media/accept-inversed.91ff05235fdd54954706eab64123a3d5.svg 1.14 kB 0%
static/css/177.b6d7c517.chunk.css 1.03 kB 0%
static/css/9282.ab6699ac.chunk.css 960 B 0%
static/media/file-pdf.51bdb15e1e5b831bcf29.svg 904 B 0%
static/js/4124.f6d79fda.chunk.js 876 B 0%
static/js/2092.9e37e313.chunk.js 874 B 0%
static/js/2967.2acff7e1.chunk.js 874 B 0%
static/css/2283.f5d3a96b.chunk.css 852 B 0%
static/css/8471.9468bdf4.chunk.css 769 B 0%
static/media/file-word.277ffb94e7a09f8a2d1a.svg 760 B 0%
static/css/9875.99507a05.chunk.css 662 B 0%
static/media/file-excel.d002b7e57fe318badf49.svg 658 B 0%
static/media/correct8-alt.30d16a7a68f9063d3141.svg 607 B 0%
static/css/5280.0d997fb0.chunk.css 601 B 0%
static/media/correct8.eac85396da602db01ea3.svg 600 B 0%
index.html 595 B 0%
static/media/twitter.a8c1622d4e18b18caa167dbe0e31135b.svg 588 B 0%
static/media/file-video.15490fa6d64ebfb4f314.svg 574 B 0%
static/css/8960.8fb0844e.chunk.css 531 B 0%
static/css/4124.0b21f13e.chunk.css 462 B 0%
static/media/navigate_far_before.8c7765f1f2719ccdf3e5.svg 403 B 0%
static/media/navigate_far_next.602e9c473cc76474ac50.svg 402 B 0%
static/media/search.bc2178ae2f929aec5f09.svg 372 B 0%
static/media/facebook.9d8980817d35c2617cf1ebb5a833369a.svg 346 B 0%
static/css/6536.5a85f720.chunk.css 345 B 0%
static/media/file.7e80f971a49227f49f7e.svg 283 B 0%
static/media/launch--white.4e75d17dfe08a3d7de03.svg 283 B 0%
static/media/launch.65e057b210ca1e5d086e.svg 268 B 0%
static/media/unfold_more.c42abd3e70207a863184.svg 257 B 0%
static/media/check_circle.afe00fa2d228d8e9212e.svg 255 B 0%
static/media/calendar_today.26e6a18c4fb766a6307e.svg 248 B 0%
static/media/error--white.7f8e755b649a0ca72ce5.svg 246 B 0%
static/media/close.53c9f4b6ba9fca553d1e.svg 239 B 0%
static/media/error.57f310a26aa85a42d2a6.svg 234 B 0%
static/media/info.b15cdce316c440127b62.svg 234 B 0%
static/media/check--blue-60v.c60440495de32668463f.svg 202 B 0%
static/media/arrow_back.037e7aeb3dbe35a36ea6.svg 198 B 0%
static/css/6074.33410131.chunk.css 197 B 0%
static/media/warning.9fcdc101f630d1fd1e97.svg 188 B 0%
static/media/expand_less.018f82c5d61abf0ebfce.svg 184 B 0%
static/media/navigate_before.f280e5b722fcf18e18a9.svg 184 B 0%
static/media/navigate_next.00940e89d53796e4fc95.svg 184 B 0%
static/media/expand_more.7bdcd63935a4c23e5b72.svg 182 B 0%
static/media/add.0ddb797a0b4996c9f281.svg 173 B 0%
static/media/remove.fb2b121df150d251453a.svg 155 B 0%
static/css/1711.9fa21f2c.chunk.css 133 B 0%
static/css/4828.241dfdc5.chunk.css 133 B 0%

@ajlusk ajlusk changed the title B 21983 MAIN - Display Counseling Office in Move Detail (Review After B-21977) B 21983 MAIN - Display Counseling Office in Move Details (Review After B-21977) Feb 4, 2025
@ajlusk ajlusk marked this pull request as ready for review February 6, 2025 15:02
@ajlusk ajlusk requested a review from a team as a code owner February 6, 2025 15:02
antgmann
antgmann reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@antgmann antgmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR has many more commits than the int pr. Int pr only has up to 3123707

@MInthavongsay
Copy link
Contributor

Seeing some extra files that are not in the INT PR. For example:

src/pages/Office/ServicesCounselingAddOrders/ServicesCounselingAddOrders.test.jsx
src/services/ghcApi.js
src/components/Office/AddOrdersForm/AddOrdersForm.test.jsx

@ajlusk
Copy link
Contributor Author

ajlusk commented Feb 6, 2025

It looks like this PR has many more commits than the int pr. Int pr only has up to 3123707

Seeing some extra files that are not in the INT PR. For example:

src/pages/Office/ServicesCounselingAddOrders/ServicesCounselingAddOrders.test.jsx src/services/ghcApi.js src/components/Office/AddOrdersForm/AddOrdersForm.test.jsx

I believe both of these are explained by merging this backlog's upstream, B-21977, into this branch. The upstream had changes after this backlog had been merged into integrationTesting. The differences should vanish when B-21977 is merged into main before this.

Perhaps I marked it ready for review prematurely.

@ajlusk ajlusk marked this pull request as draft February 6, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antgmann antgmann antgmann left review comments

@MInthavongsay MInthavongsay Awaiting requested review from MInthavongsay

@r-mettler r-mettler Awaiting requested review from r-mettler

@CoryKleinjanCACI CoryKleinjanCACI Awaiting requested review from CoryKleinjanCACI

At least 2 approving reviews are required to merge this pull request.

Assignees

@ajlusk ajlusk

Labels
MAIN Scrummy Bears Scrum Team H
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajlusk @MInthavongsay @antgmann