Expose UI version number in transcend.version
#165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request has been linked to and will mark 1 task as "Pending Deploy" when merged:
|
eligrey
changed the title
transcend.versiontranscend.version
|
What's the reasoning behind this PR? We don't publish ui versions independently of airgap so not sure this is useful... |
anotherminh
reviewed
May 29, 2024
| @@ -91,7 +91,7 @@ export const build = async ( | |||
| } | |||
| : undefined, | |||
| define: { | |||
| 'process.env.version': JSON.stringify( | |||
| 'process.env.VERSION': JSON.stringify( | |||
There was a problem hiding this comment.
best practice for env constants to prevent accidental mis-use (e.g. as a variable that can be assigned to)
anotherminh
previously approved these changes
May 29, 2024
eligrey
changed the title
transcend.versiontranscend.version
This reverts commit 4eafe04.
|
The reasoning behind this PR is to improve the debugging flow for UI bugs on customer sites so that we can immediately pinpoint their UI version. |
anotherminh
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Security Implications
[none]
System Availability
[none]