Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GDPR default regional experience to include consent expiry #128

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Update GDPR default regional experience to include consent expiry #128

merged 2 commits into from
Feb 1, 2024

Conversation

linh-transcend
Copy link
Member

@linh-transcend linh-transcend commented Jan 31, 2024 •
edited
Loading

Related Issues

  • links https://transcend.height.app/T-33233
  • Adds consentExpiry and onConsentExpiry to experience defaults. Sets GDPR to consentExpiry = 12 and onConsentExpiry = ResetOptIns
  • Will follow up w/a PR to update the version of airgap.js-types in the monorepo + add tests to the createDefaultExperiences helper.

Security Implications

[none]

System Availability

[none]

@height Height
Copy link

height bot commented Jan 31, 2024 •
edited
Loading

This pull request has been linked to 1 task:

💡Tip: Add "Close T-33233" to the pull request title or description, to a commit message, or in a comment to mark this task as "Pending Deploy" when the pull request is merged.

@linh-transcend linh-transcend requested review from a team and blake-transcend February 1, 2024 14:47
MadDataScience
MadDataScience approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@MadDataScience MadDataScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@linh-transcend linh-transcend merged commit 6970526 into main Feb 1, 2024
10 checks passed
@delete-merged-branch delete-merged-branch bot deleted the linh-transcend/update-gdpr-default branch February 1, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadDataScience MadDataScience MadDataScience approved these changes

@blake-transcend blake-transcend Awaiting requested review from blake-transcend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linh-transcend @MadDataScience