Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New view state: PrivacyPolicyNoticeWithCloseButton #126

Merged
merged 2 commits into from
Jan 4, 2024
Merged

New view state: PrivacyPolicyNoticeWithCloseButton #126

merged 2 commits into from
Jan 4, 2024

Conversation

michaelfarrell76
Copy link
Member

@michaelfarrell76 michaelfarrell76 requested review from banzzai, anotherminh and a team January 4, 2024 21:55
@height Height
Copy link

height bot commented Jan 4, 2024 •
edited
Loading

This pull request has been linked to 1 task:

💡Tip: Add "Close T-30875" to the pull request title or description, to a commit message, or in a comment to mark this task as "Pending Deploy" when the pull request is merged.

eligrey
eligrey previously approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@eligrey eligrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's too late for PrivacyPolicyNoticeWithCloseButton? PrivacyPolicyNoticeWithX is fine but it could be a tad more semantic

@michaelfarrell76
Copy link
Member Author

@eligrey not too late - doing now!

@michaelfarrell76 michaelfarrell76 force-pushed the michaelfarrell76/privacy-policy-notice branch from 1bd2af2 to c10d8dc Compare January 4, 2024 23:03
@banzzai
Copy link
Member

banzzai commented Jan 4, 2024

That's mostly just the version bump here, right

@michaelfarrell76
Copy link
Member Author

@banzzai yes - and i added the new view state to the enum definition defining all of the view states

@michaelfarrell76 michaelfarrell76 changed the title New view state: PrivacyPolicyNoticeWithX New view state: PrivacyPolicyNoticeWithCloseButton Jan 4, 2024
@michaelfarrell76 michaelfarrell76 merged commit 53c00e2 into main Jan 4, 2024
10 checks passed
@delete-merged-branch delete-merged-branch bot deleted the michaelfarrell76/privacy-policy-notice branch January 4, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banzzai banzzai banzzai approved these changes

@eligrey eligrey eligrey approved these changes

@anotherminh anotherminh Awaiting requested review from anotherminh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelfarrell76 @banzzai @eligrey