Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand TCF config, defaults #116

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Expand TCF config, defaults #116

merged 2 commits into from
Nov 30, 2023

Conversation

anotherminh
Copy link
Member

@anotherminh anotherminh commented Nov 30, 2023

Related Issues

Security Implications

[none]

System Availability

[none]

@anotherminh anotherminh requested a review from a team November 30, 2023 19:33
@@ -55,3 +55,6 @@ export const REGIME_DISPLAY_PRIORITY: Record<PrivacyRegime, number> = {
GDPR: 10,
Unknown: 100,
};

/** These TCF Purposes cannot be allowed to process under legitimate interest legal basis */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we add a reference for this fact? I assume you got it from some IAB doc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do once.. i find it

Comment on lines +233 to +234
/** These TCF purposes cannot be processed on the basis of legitimate interests */
restrictLegitimateInterestPurposes: t.array(t.number),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully get this, but I'll read up on the ticket for context.

@anotherminh anotherminh merged commit 6d21672 into main Nov 30, 2023
10 checks passed
@delete-merged-branch delete-merged-branch bot deleted the anotherminh/tcf-full-config branch November 30, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants