create runtime types for reserved metadata #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
|
|
||
| const ReservedMetadata = t.partial({ | ||
| tcmp: t.partial({ |
There was a problem hiding this comment.
I'm not the most update to date but what does tcmp represent?
There was a problem hiding this comment.
So we're storing some "reserved" metadata that we don't want customers to access, and rather than putting them as top level keys where we might have to worry about collisions our communicating to customers to avoid these keywords, we're grouping them all under a tcmp field to shrink the chance of collision as much as possible
There was a problem hiding this comment.
So a tcmp field is just a nested field to sorta hide these values that we don't want the customer to see?
There was a problem hiding this comment.
Yep, exactly! Then the values themselves are just arbitrary module data that we want synced
linh-transcend
approved these changes
Nov 21, 2023
delete-merged-branch
bot
deleted the
csmccarthy/reserved-metadata-io-ts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Changelog
Creating a runtime type for our new reserved metadata, mostly so that we can pull it out in the lambda and store it in the preference store as a top level key