Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export experience.ts from index file #107

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Export experience.ts from index file #107

merged 2 commits into from
Nov 13, 2023

Conversation

bencmbrook
Copy link
Member

Related Issues

  • [none]

Security Implications

[none]

System Availability

[none]

@bencmbrook
Copy link
Member Author

Currently importing like so Screenshot 2023-11-13 at 2 35 03 PM

csmccarthy
csmccarthy previously approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@csmccarthy csmccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I totally missed this with the code cleanup, thank you !!

@csmccarthy
Copy link
Member

Oh don't forget to bump the package version also

csmccarthy
csmccarthy approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@csmccarthy csmccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ty ty

@bencmbrook bencmbrook merged commit c39c740 into main Nov 13, 2023
10 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bencmbrook-patch-1 branch November 13, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csmccarthy csmccarthy csmccarthy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bencmbrook @csmccarthy