Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npic false positive #1540

Open
wants to merge 5 commits into
base: register-npic
Choose a base branch
from
Open

Fix npic false positive #1540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6358de
Account for Cargo's new hashing algorithm
smoelius Feb 20, 2025
b30fcdd
Update lockfiles
smoelius Feb 21, 2025
7d1cc74
Update supply chain files
smoelius Feb 21, 2025
9e2be5e
Bump version
smoelius Feb 21, 2025
4513ce0
fix(npic): address false positives in path detection
augustin-v Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 4.0.0

- BREAKING CHANGE: Work with [Cargo's new hashing algorithm](https://github.com/rust-lang/cargo/pull/14917), introduced with Rust 1.85.0. `cargo-dylint` 4 does not work with Cargo 1.84.x and earlier, and `cargo-dylint` 3.x does not work with Cargo 1.85.0. If you need to use Cargo 1.84.x or earlier, please continue to use `cargo-dylint` 3.x. If you have a long term need to use Cargo 1.84.x or earlier, please [open an issue](https://github.com/trailofbits/dylint/issues). ([#1534](https://github.com/trailofbits/dylint/pull/1534))

## 3.5.1

- Have `cargo metadata` and `cargo fetch` use the same `cargo` when building library packages. Using different `cargo`s caused the two commands to refer to different subdirectories within the user's `CARGO_HOME`, leading to "Could not determine accessed subdirectory" errors. This bug primarily affected projects with `rust-toolchain` files. ([#1519](https://github.com/trailofbits/dylint/pull/1519))
Expand Down
87 changes: 47 additions & 40 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ predicates = "3.1"
regex = "1.11"
rewriter = "0.1"
rust-embed = "8.5"
rustc-stable-hash = "0.1"
rustversion = "1.0"
semver = "1.0"
serde = "1.0"
Expand Down
8 changes: 4 additions & 4 deletions cargo-dylint/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "cargo-dylint"
version = "3.5.1"
version = "4.0.0"
authors = ["Samuel E. Moelius III <[email protected]>"]
description = "A tool for running Rust lints from dynamic libraries"
edition = "2021"
Expand All @@ -16,10 +16,10 @@ anyhow = { workspace = true, features = ["backtrace"] }
clap = { workspace = true, features = ["cargo", "derive", "wrap_help"] }
env_logger = { workspace = true }

dylint = { version = "=3.5.1", path = "../dylint", features = [
dylint = { version = "=4.0.0", path = "../dylint", features = [
"package_options",
] }
dylint_internal = { version = "=3.5.1", path = "../internal" }
dylint_internal = { version = "=4.0.0", path = "../internal" }

[dev-dependencies]
assert_cmd = { workspace = true }
Expand All @@ -36,7 +36,7 @@ similar-asserts = { workspace = true }
tempfile = { workspace = true }
walkdir = { workspace = true }

dylint_internal = { version = "=3.5.1", path = "../internal", features = [
dylint_internal = { version = "=4.0.0", path = "../internal", features = [
"examples",
"testing",
] }
Expand Down
Loading
Loading