Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't draw crosshair lines after mouse leaves chart pane #1776

Merged

Conversation

SlicedSilver
Copy link
Contributor

Type of PR: bugfix (regression added during v4 to v5 changes)

PR checklist:

  • Addresses an existing issue: (no issue created)
  • Includes tests
  • N/A Documentation update

Overview of change:
When the mouse (pointer) leaves the chart pane then it is expected that the chart should stop drawing the crosshair.

A one-line code change to trigger a updateAllViews was all that was required to fix the issue.

@SlicedSilver SlicedSilver added the bug Unexpected problem or unintended behavior. label Jan 20, 2025
@SlicedSilver SlicedSilver added this to the 5.0 milestone Jan 20, 2025
@SlicedSilver SlicedSilver requested a review from illetid January 20, 2025 17:08
@SlicedSilver SlicedSilver self-assigned this Jan 20, 2025
Copy link

size-limit report 📦

Path Size
ESM 44.82 KB (-0.02% 🔽)
ESM createChart 36.83 KB (+0.11% 🔺)
ESM createChartEx 35.51 KB (-0.02% 🔽)
ESM createYieldCurveChart 37.01 KB (+0.07% 🔺)
ESM createOptionsChart 35.74 KB (-0.01% 🔽)
Standalone-ESM 46.27 KB (-0.18% 🔽)
Standalone 46.26 KB (+0.1% 🔺)
Plugin: Text Watermark 1.87 KB (0%)
Plugin: Image Watermark 1.69 KB (0%)
Plugin: Series Markers 3.98 KB (0%)
Series: LineSeries 2.54 KB (0%)
Series: BaselineSeries 3.2 KB (0%)
Series: AreaSeries 3.12 KB (0%)
Series: BarSeries 2.15 KB (0%)
Series: CandlestickSeries 2.42 KB (0%)
Series: HistogramSeries 2.18 KB (0%)
Plugin: UpDownMarkersPrimitive 2.37 KB (0%)

Copy link
Contributor

@illetid illetid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@SlicedSilver SlicedSilver merged commit cd6f9c8 into v5-candidate Jan 20, 2025
28 of 33 checks passed
@SlicedSilver SlicedSilver deleted the dont-draw-crosshair-when-mouse-outside-pane branch January 20, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants