Graphics e2e tests syntax mode #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
SlicedSilver
force-pushed
the
graphics-e2e-tests-syntax-mode
branch
2 times, most recently
from
2e8efd6 to
9a1c615
Compare
SlicedSilver
force-pushed
the
graphics-e2e-tests-syntax-mode
branch
from
9a1c615 to
c67a4d4
Compare
SlicedSilver
added
the
infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR: infrastructure
Overview of change:
Adds a mode for running the graphics test such that the golden case uses the test case code from the golden branch. This will be useful testing changes to API (such that the test case code is changed and can only run in the new branch).
Additionally fixes the graphics pipeline when running on the CI. Previously a single failing test would fail all the remaining test cases as well.
How to run:
Authorised users can trigger the pipeline on a specific branch with the
run_branch_specific_graphics_testsparameter set totruethrough the CircleCI site.Note: it will only work if the 'golden' branch has the code in this PR.