Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split graphics tests on CI #1661

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Conversation

SlicedSilver
Copy link
Contributor

Type of PR: Infrastructure

Overview of Change:

This PR optimizes our Circle-CI pipeline by parallelizing the graphics tests, significantly reducing overall execution time.

Key Changes:

  1. Test Parallelization:

    • Split graphics tests into 3 roughly equal parts.
    • Implemented using the grep parameter in the graphics test runner.
    • Increased from 5 to 15 jobs, running in parallel.
  2. Configuration Optimization:

    • Utilized Circle-CI's matrix feature for efficient job definition.
    • Implemented YAML anchors to reduce redundancy in config.yml.
  3. Performance Impact:

    • Expected significant reduction in total pipeline execution time.
    • Maintains comprehensive test coverage while improving CI efficiency.

Technical Details:

  • No changes to test cases or runner logic.
  • Modifications confined to Circle-CI configuration.
  • Leveraged Circle-CI's advanced features for scalable and maintainable config.

Benefits:

  • Faster feedback on PRs and merges.
  • More efficient use of CI resources.
  • Improved developer experience with quicker build times.

Potential Considerations:

  • May require adjustments if test suite composition changes significantly.

@SlicedSilver SlicedSilver added the infrastructure Infrastructure surrounding the development of the library (CI, tests, scripts). label Jul 30, 2024
Copy link

github-actions bot commented Jul 30, 2024

size-limit report 📦

Path Size
ESM 42.44 KB (0%)
ESM createChart 42.23 KB (0%)
ESM createChartEx 40.89 KB (0%)
Standalone-ESM 43.92 KB (0%)
Standalone 43.9 KB (0%)

@SlicedSilver SlicedSilver marked this pull request as ready for review July 30, 2024 15:11
@SlicedSilver SlicedSilver self-assigned this Jul 30, 2024
@SlicedSilver SlicedSilver merged commit 735ebfe into v5-candidate Jul 30, 2024
33 checks passed
@SlicedSilver SlicedSilver deleted the split-graphics-tests-on-ci branch July 30, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure surrounding the development of the library (CI, tests, scripts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant