Merge branch 'v5-candidate' into feature/add-series-tree-shakable

tradingview · Nov 11, 2024 · 7c7015f · 7c7015f
2 parents 140a653 + d050b3a
commit 7c7015f
Show file tree

Hide file tree

Showing 26 changed files with 747 additions and 535 deletions.
diff --git a/src/api/chart-api.ts b/src/api/chart-api.ts
@@ -1,3 +1,4 @@
+/// <reference types="_build-time-constants" />
 import { ChartWidget, MouseEventParamsImpl, MouseEventParamsImplSupplier } from '../gui/chart-widget';
 
 import { assert, ensure, ensureDefined } from '../helpers/assertions';
@@ -264,6 +265,16 @@ export class ChartApi<HorzScaleItem> implements IChartApiBase<HorzScaleItem>, Da
 	}
 
 	public applyOptions(options: DeepPartial<ChartOptionsImpl<HorzScaleItem>>): void {
+		if (process.env.NODE_ENV === 'development') {
+			const colorSpace = options.layout?.colorSpace;
+			if (colorSpace !== undefined && colorSpace !== this.options().layout.colorSpace) {
+				throw new Error(`colorSpace option should not be changed once the chart has been created.`);
+			}
+			const colorParsers = options.layout?.colorParsers;
+			if (colorParsers !== undefined && colorParsers !== this.options().layout.colorParsers) {
+				throw new Error(`colorParsers option should not be changed once the chart has been created.`);
+			}
+		}
 		this._chartWidget.applyOptions(toInternalOptions(options));
 	}
 

diff --git a/src/api/options/layout-options-defaults.ts b/src/api/options/layout-options-defaults.ts
@@ -16,4 +16,6 @@ export const layoutOptionsDefaults: LayoutOptions = {
 		separatorHoverColor: 'rgba(178, 181, 189, 0.2)',
 	},
 	attributionLogo: true,
+	colorSpace: 'srgb',
+	colorParsers: [],
 };
diff --git a/src/gui/attribution-logo-widget.ts b/src/gui/attribution-logo-widget.ts
@@ -1,5 +1,3 @@
-import { colorStringToGrayscale } from '../helpers/color';
-
 import { IChartWidgetBase } from './chart-widget';
 
 type LogoTheme = 'dark' | 'light';
@@ -44,7 +42,12 @@ export class AttributionLogoWidget {
 	}
 
 	private _themeToUse(): LogoTheme {
-		return colorStringToGrayscale(this._chart.options()['layout'].textColor) > 160 ? 'dark' : 'light';
+		return this._chart
+			.model()
+			.colorParser()
+			.colorStringToGrayscale(this._chart.options()['layout'].textColor) > 160
+			? 'dark'
+			: 'light';
 	}
 
 	private _shouldBeVisible(): boolean {

diff --git a/src/gui/pane-widget.ts b/src/gui/pane-widget.ts
@@ -484,9 +484,13 @@ export class PaneWidget implements IDestroyable, MouseEventHandlers {
 			this._rightPriceAxisWidget.paint(type);
 		}
 
+		const canvasOptions: CanvasRenderingContext2DSettings = {
+			colorSpace: this._chart.options().layout.colorSpace,
+		};
+
 		if (type !== InvalidationLevel.Cursor) {
 			this._canvasBinding.applySuggestedBitmapSize();
-			const target = tryCreateCanvasRenderingTarget2D(this._canvasBinding);
+			const target = tryCreateCanvasRenderingTarget2D(this._canvasBinding, canvasOptions);
 			if (target !== null) {
 				target.useBitmapCoordinateSpace((scope: BitmapCoordinatesRenderingScope) => {
 					this._drawBackground(scope);
@@ -501,7 +505,7 @@ export class PaneWidget implements IDestroyable, MouseEventHandlers {
 		}
 
 		this._topCanvasBinding.applySuggestedBitmapSize();
-		const topTarget = tryCreateCanvasRenderingTarget2D(this._topCanvasBinding);
+		const topTarget = tryCreateCanvasRenderingTarget2D(this._topCanvasBinding, canvasOptions);
 		if (topTarget !== null) {
 			topTarget.useBitmapCoordinateSpace(({ context: ctx, bitmapSize }: BitmapCoordinatesRenderingScope) => {
 				ctx.clearRect(0, 0, bitmapSize.width, bitmapSize.height);

diff --git a/src/gui/price-axis-stub.ts b/src/gui/price-axis-stub.ts
@@ -101,7 +101,9 @@ export class PriceAxisStub implements IDestroyable {
 		this._invalidated = false;
 
 		this._canvasBinding.applySuggestedBitmapSize();
-		const target = tryCreateCanvasRenderingTarget2D(this._canvasBinding);
+		const target = tryCreateCanvasRenderingTarget2D(this._canvasBinding, {
+			colorSpace: this._options.layout.colorSpace,
+		});
 		if (target !== null) {
 			target.useBitmapCoordinateSpace((scope: BitmapCoordinatesRenderingScope) => {
 				this._drawBackground(scope);

diff --git a/src/gui/price-axis-widget.ts b/src/gui/price-axis-widget.ts
@@ -250,7 +250,11 @@ export class PriceAxisWidget implements IDestroyable {
 		let tickMarkMaxWidth = 0;
 		const rendererOptions = this.rendererOptions();
 
-		const ctx = ensureNotNull(this._canvasBinding.canvasElement.getContext('2d'));
+		const ctx = ensureNotNull(
+			this._canvasBinding.canvasElement.getContext('2d', {
+				colorSpace: this._pane.chart().options().layout.colorSpace,
+			})
+		);
 		ctx.save();
 
 		const tickMarks = this._priceScale.marks();
@@ -345,11 +349,13 @@ export class PriceAxisWidget implements IDestroyable {
 		if (this._size === null) {
 			return;
 		}
-
+		const canvasOptions: CanvasRenderingContext2DSettings = {
+			colorSpace: this._pane.chart().options().layout.colorSpace,
+		};
 		if (type !== InvalidationLevel.Cursor) {
 			this._alignLabels();
 			this._canvasBinding.applySuggestedBitmapSize();
-			const target = tryCreateCanvasRenderingTarget2D(this._canvasBinding);
+			const target = tryCreateCanvasRenderingTarget2D(this._canvasBinding, canvasOptions);
 			if (target !== null) {
 				target.useBitmapCoordinateSpace((scope: BitmapCoordinatesRenderingScope) => {
 					this._drawBackground(scope);
@@ -363,7 +369,7 @@ export class PriceAxisWidget implements IDestroyable {
 		}
 
 		this._topCanvasBinding.applySuggestedBitmapSize();
-		const topTarget = tryCreateCanvasRenderingTarget2D(this._topCanvasBinding);
+		const topTarget = tryCreateCanvasRenderingTarget2D(this._topCanvasBinding, canvasOptions);
 		if (topTarget !== null) {
 			topTarget.useBitmapCoordinateSpace(({ context: ctx, bitmapSize }: BitmapCoordinatesRenderingScope) => {
 				ctx.clearRect(0, 0, bitmapSize.width, bitmapSize.height);

diff --git a/src/gui/time-axis-widget.ts b/src/gui/time-axis-widget.ts
@@ -298,10 +298,12 @@ export class TimeAxisWidget<HorzScaleItem> implements MouseEventHandlers, IDestr
 		if (type === InvalidationLevel.None) {
 			return;
 		}
-
+		const canvasOptions: CanvasRenderingContext2DSettings = {
+			colorSpace: this._options.colorSpace,
+		};
 		if (type !== InvalidationLevel.Cursor) {
 			this._canvasBinding.applySuggestedBitmapSize();
-			const target = tryCreateCanvasRenderingTarget2D(this._canvasBinding);
+			const target = tryCreateCanvasRenderingTarget2D(this._canvasBinding, canvasOptions);
 			if (target !== null) {
 				target.useBitmapCoordinateSpace((scope: BitmapCoordinatesRenderingScope) => {
 					this._drawBackground(scope);
@@ -324,7 +326,7 @@ export class TimeAxisWidget<HorzScaleItem> implements MouseEventHandlers, IDestr
 		}
 
 		this._topCanvasBinding.applySuggestedBitmapSize();
-		const topTarget = tryCreateCanvasRenderingTarget2D(this._topCanvasBinding);
+		const topTarget = tryCreateCanvasRenderingTarget2D(this._topCanvasBinding, canvasOptions);
 		if (topTarget !== null) {
 			topTarget.useBitmapCoordinateSpace(({ context: ctx, bitmapSize }: BitmapCoordinatesRenderingScope) => {
 				ctx.clearRect(0, 0, bitmapSize.width, bitmapSize.height);