Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs): Add ECS cluster and task to CDK #3

Open
wants to merge 5 commits into
base: feat/spotfleet-mgmt-ui
Choose a base branch
from
Open

feat(ecs): Add ECS cluster and task to CDK #3

wants to merge 5 commits into from

Conversation

ClarisseEynard
Copy link
Collaborator

No description provided.

@nathanagez
Copy link
Member

Please rename your PR: feat(ecs): Add ECS cluster and task to CDK instead of feat(python): Add ECS cluster and task to CD.

The feature you are working on is ECS

@nathanagez nathanagez requested a review from Pipchild February 23, 2024 08:45
@ClarisseEynard ClarisseEynard changed the title feat(python): Add ECS cluster and task to CDK feat(ecs): Add ECS cluster and task to CDK Feb 23, 2024
Pipchild
Pipchild requested changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@Pipchild Pipchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced with Clarisse, various change requested

@maramtrackIT maramtrackIT force-pushed the feat/spotfleet-mgmt-ui branch from 03c3736 to c01bdc2 Compare February 29, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanagez nathanagez Awaiting requested review from nathanagez

@Pipchild Pipchild Awaiting requested review from Pipchild

Assignees

@ClarisseEynard ClarisseEynard

Labels
After NAB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ClarisseEynard @nathanagez @Pipchild