-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: completed the vertexai provider integration #21
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Gmin2! Can you add support for streaming as well?
Hey @Gmin2, Please copy, the "Definition of Done" defined in the issue to the PR, and mark everything you've done. |
hey @galkleinman, what it is meant by |
can i get a review |
Implemented function calling, image, video and audio capabilities of the vertexai provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some major changes requests (before I deep dive into the implementation):
- The whole point of this hub/router, is that you use the OpenAI sdk/api to call w/e provider/model you want. The routing is based on a selected pipeline header, which can either support the functionality (either chat, vision, audio...) or not. While you can multiple pipelines support the same functionality with different models or pipeline for team etc... Each pipeline, should expose the same API as openai exposes and implement it internally. With the current implementation you've changed the routing mechanism of the hub and the exposed api.
- Tests aren't reproducible since they count on existence of api keys, models and therefore can't be used in CI. use surf-vcr or any preferred network recording solution to create test recordings which will make it reproducible .
c688574
to
7953568
Compare
I will do the multimodality part in a seperate PR
Done Can i get a review for now ? cc @nirga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Gmin2 can you take a look at the tests? They seem to be failing
Completed the integration of vertexAI
Screencast.from.24-12-24.03.01.59.PM.IST.webm
Integration test
Unit test
fix #19
/claim #19