Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Data and DataSerialize #2703

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laggui
Copy link
Member

@laggui laggui commented Jan 15, 2025

Checklist

  • Confirmed that run-checks all script has been executed.

Changes

Some maintenance work.

Officially removed the deprecated Data and DataSerialize structs and, in turn, record-backward-compat flag. It's been 3 releases since they have been deprecated.

I still left the README note and error message for the time being.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.36%. Comparing base (93cafc4) to head (ad3c1e8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-core/src/record/tensor.rs 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2703      +/-   ##
==========================================
+ Coverage   83.19%   83.36%   +0.16%     
==========================================
  Files         819      819              
  Lines      106748   106608     -140     
==========================================
+ Hits        88811    88870      +59     
+ Misses      17937    17738     -199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants