-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue4299 #4434
Open
UnABC
wants to merge
8
commits into
master
Choose a base branch
from
issue4299
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+111
−19
Open
Issue4299 #4434
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c1c88b5
リアクションのホバー時に拡大表示する機能の追加
8d05380
ホバー時、リアクションした人も分かるように
acd6832
format
Pugma 0101b00
titleを削除
ec87df5
aria-label属性を追加(フォーマットはDiscordに合わせた)
e50a748
rum formatで引っかかったので修正
6bbdefe
コードを整形
7c3878d
ポップアップが画面の端に来ると表示が壊れる不具合の修正およびポップアップがツールバーより上に来るように修正
UnABC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
src/components/Main/MainView/MessageElement/StampScaledElement.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
<template> | ||
<div v-show="show" :class="$style.scaleReaction"> | ||
<transition name="scale-reaction"> | ||
<!-- sizeを46より大きくすると見切れる --> | ||
<a-stamp | ||
:key="stamp.id" | ||
:stamp-id="stamp.id" | ||
:size="46" | ||
:class="$style.stamp" | ||
without-title | ||
/> | ||
</transition> | ||
<stamp-detail-element :class="$style.detail" :stamp="stamp" /> | ||
</div> | ||
</template> | ||
|
||
<script lang="ts" setup> | ||
import AStamp from '/@/components/UI/AStamp.vue' | ||
import type { MessageStampById } from '/@/lib/messageStampList' | ||
import StampDetailElement from './StampDetailElement.vue' | ||
|
||
const props = defineProps<{ | ||
stamp: MessageStampById | ||
show: boolean | ||
}>() | ||
</script> | ||
|
||
<style lang="scss" module> | ||
.scaleReaction { | ||
@include color-ui-tertiary; | ||
@include background-primary; | ||
display: flex; | ||
border-radius: 4px; | ||
contain: none; | ||
flex-wrap: wrap; | ||
border: solid 2px $theme-ui-tertiary-default; | ||
} | ||
.stamp { | ||
margin: { | ||
right: 0.2rem; | ||
bottom: 0.2rem; | ||
} | ||
display: flex; | ||
} | ||
|
||
.detail { | ||
color: var(--specific-count-text); | ||
@include color-ui-primary; | ||
max-width: 500px; | ||
min-width: 0; | ||
overflow: hidden; | ||
overflow: clip; | ||
margin: { | ||
left: 6px; | ||
right: 4px; | ||
} | ||
} | ||
</style> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
今の状態だと、↑の画像みたいにマウスホバー時のポップアップが 2 つ同時に出てしまうので
title
属性を消していいと思いますただ、これをしてしまうと a11y (アクセシビリティ) の観点から困ったことになる可能性もあるので、
aria-label
などの属性に切り替えるのを検討したほうがいいと思いますThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title
属性を消去してaria-label
属性に切り替えましたDiscordを参考にして
aria-label
の内容を定めたのでa11yの観点からも問題はないと思われます