Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share-target API のテキストが下書きで上書きされるバグを修正 #4431

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nagarei
Copy link
Contributor

@Nagarei Nagarei commented Jan 3, 2025

close #4430
VirtualChannelIdに対してはmessageInputStateStoreを使わないようにした

vueもtypescriptもjavascriptも書いたことのないので悪い書き方かもしれないです。適宜修正してください。

Copy link

github-actions bot commented Jan 3, 2025

@Nagarei Nagarei marked this pull request as ready for review January 3, 2025 03:35
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 9.26%. Comparing base (8541fd6) to head (5369b3b).
Report is 207 commits behind head on master.

Files with missing lines Patch % Lines
src/store/ui/messageInputStateStore.ts 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #4431       +/-   ##
==========================================
- Coverage   86.41%   9.26%   -77.15%     
==========================================
  Files          66     650      +584     
  Lines        4747   28005    +23258     
  Branches      503     521       +18     
==========================================
- Hits         4102    2595     -1507     
- Misses        639   25404    +24765     
  Partials        6       6               
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

share-target API のテキストが空文字になる
1 participant