Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FormButton の primary で枠線の色が変わってしまっていた #4152

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

SSlime-s
Copy link
Member

@SSlime-s SSlime-s commented Nov 15, 2023

ダークモードだとわかりやすい

before (変わっちゃってる状態) after (正常)
image image

原因: #4146

@SSlime-s SSlime-s requested a review from mehm8128 November 15, 2023 15:26
@SSlime-s SSlime-s self-assigned this Nov 15, 2023
Copy link

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (016a60a) 86.35% compared to head (d0a0cc7) 86.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4152   +/-   ##
=======================================
  Coverage   86.35%   86.35%           
=======================================
  Files          66       66           
  Lines        4719     4719           
  Branches      564      564           
=======================================
  Hits         4075     4075           
  Misses        638      638           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nokhnaton nokhnaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直ってそうです:+1:

@mehm8128 mehm8128 merged commit dcb6688 into master Nov 16, 2023
12 checks passed
@mehm8128 mehm8128 deleted the SSlime/fix-form-button-primary branch November 16, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants