Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

特定のバージョン以上のipadでもモーダルがクリックで閉じられるように #4117

Merged
merged 3 commits into from
Oct 27, 2023
Merged

特定のバージョン以上のipadでもモーダルがクリックで閉じられるように #4117

merged 3 commits into from
Oct 27, 2023

Conversation

mehm8128
Copy link
Contributor

@mehm8128 mehm8128 commented Oct 27, 2023 •
edited
Loading

close #4003

参考: https://qiita.com/ShingoFukuyama/items/ef573a8e3e23ef12542e, https://iwb.jp/ipad-safari-javascript-useragent-is-not-ipad/, https://jsnotice.com/posts/2019-09-08/index.html

以下2点が確認できたらマージします

  • iPadで動作確認
  • macOSでも今と変わらず閉じられることの確認

@mehm8128 mehm8128 self-assigned this Oct 27, 2023
@github-actions
Copy link

Preview (prod) → https://4117-prod.traq-preview.trapti.tech/
Preview (dev) → https://4117-dev.traq-preview.trapti.tech/

@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/lib/dom/browser.ts 70.96% <90.90%> (+2.29%) ⬆️

📢 Thoughts on this report? Let us know!.

nokhnaton
nokhnaton approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@nokhnaton nokhnaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作確認がされたら大丈夫そうです

@mehm8128 mehm8128 marked this pull request as draft October 27, 2023 08:44
@mehm8128
Copy link
Contributor Author

あ、approveされたけどdraftに戻しちゃった
これだとiPad以外でもmacでisIOSがtrueになっちゃう気がしました

@nokhnaton
Copy link
Contributor

あ、確かにそうですね

@nokhnaton nokhnaton self-requested a review October 27, 2023 08:47
@mehm8128
Copy link
Contributor Author

これでいけるのかな、どうだろ
参考文献も追加しました

@mehm8128 mehm8128 marked this pull request as ready for review October 27, 2023 08:57
@motoki317
Copy link
Member

参考はPRのdescだけじゃなくてコード中に書いても良さそう

@mehm8128
Copy link
Contributor Author

確かにそうですね、書いておきます

nokhnaton
nokhnaton approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@nokhnaton nokhnaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macでもちゃんと動いてそう

@mehm8128 mehm8128 merged commit 0ef6320 into master Oct 27, 2023
11 checks passed
@mehm8128 mehm8128 deleted the fix/modal_close_on_ipad branch October 27, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jippo-m jippo-m jippo-m approved these changes

@nokhnaton nokhnaton nokhnaton approved these changes

@logica0419 logica0419 Awaiting requested review from logica0419

Assignees

@mehm8128 mehm8128

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

各種モーダルがiPadだと外側をクリックしても閉じられない
4 participants
@mehm8128 @nokhnaton @motoki317 @jippo-m