Issue4299 #4434
Open
Issue4299 #4434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://4434-prod.traq-preview.trapti.tech/ |
added 2 commits
January 4, 2025 23:47
Pugma
requested changes
Jan 4, 2025
| @@ -4,6 +4,8 @@ | |||
| :title="tooltip" | |||
There was a problem hiding this comment.
今の状態だと、↑の画像みたいにマウスホバー時のポップアップが 2 つ同時に出てしまうので title 属性を消していいと思います
ただ、これをしてしまうと a11y (アクセシビリティ) の観点から困ったことになる可能性もあるので、 aria-label などの属性に切り替えるのを検討したほうがいいと思います
Suggested change
| :title="tooltip" | |
| <!-- :title="tooltip" ここを消す --> |
There was a problem hiding this comment.
title属性を消去してaria-label属性に切り替えました
Discordを参考にしてaria-labelの内容を定めたのでa11yの観点からも問題はないと思われます
Pugma
requested changes
Jan 6, 2025
|
対応完了しました |
|
確認したんですが、今の状態でも 2 列に収まらない場合はそれ以降のスタンプを押した人の名前が表示されなくなってそうです (本番環境で確認しました) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
リアクションをホバーしたときに拡大して表示して欲しい #4433