ベンチマーク関連ページの実装 #26
Open
ベンチマーク関連ページの実装 #26
+683
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikura-hamu
requested changes
Jan 8, 2025
| </div> | ||
| </div> | ||
| <div class="bench-log-container"> | ||
| <pre><code>{{ log }}</code></pre> |
There was a problem hiding this comment.
そもそも行数を付ける気はなかったです (コードではないので、行数はいらなさそう & たぶんベンチマークのログに時刻がついてる)
| </script> | ||
|
|
||
| <template> | ||
| <div class="bench-list"> |
There was a problem hiding this comment.
スコアで並び替えたり実行ユーザーとかステータスで絞り込めたらうれしいかも
後からでもいい
There was a problem hiding this comment.
ちょっとめんどくさいので、後からやることにします
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
#27 がないと型エラーが起きる |
ikura-hamu
reviewed
Jan 9, 2025
| <div v-if="bench" class="bench-detail-container"> | ||
| <div class="bench-score-container"> | ||
| <div class="bench-score-label">スコア</div> | ||
| <div v-if="bench.score !== undefined" class="bench-score-content">{{ bench.score }}</div> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.