部屋に関するAPIを追加 #150
Open
部屋に関するAPIを追加 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akimon658
commented
Feb 2, 2025
|
あと追加で、マイグレーションに関しては自動で行われなくなったので
必要があります。v4.goの内容はv3.goと同じで大丈夫です |
|
めっちゃ参考になります、ありがとう！！ やります |
|
とりあえず指摘をもらった部分の修正はしました。時間あるとき再確認お願いします 🙏 |
|
LGTMです！動作確認していないのでまだ僕の方でマージはしませんが、フロントの方で必要になったら勝手にマージしても良いです |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #130
TODO:
migrationディレクトリに追加する必要がある。多分AutoMigrationだけでOK）