Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce replaceTime #53

Merged
merged 3 commits into from
Feb 3, 2025
Merged

feat: introduce replaceTime #53

merged 3 commits into from
Feb 3, 2025
+62 −18

Conversation

cp-20
Copy link
Collaborator

@cp-20 cp-20 commented Feb 3, 2025

replace にかかる時間の合計を記録して、ExportMetrics を良い感じにソートした

@cp-20 cp-20 requested a review from pirosiki197 February 3, 2025 11:19
@cp-20 cp-20 self-assigned this Feb 3, 2025
pirosiki197
pirosiki197 approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@pirosiki197 pirosiki197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです。少しだけコメントしましたが、いい感じに直したらmergeしちゃってください

template/cache.go Outdated Show resolved Hide resolved
template/cache.go Show resolved Hide resolved
template/driver.go Outdated Show resolved Hide resolved
@cp-20 cp-20 merged commit 9ce19ba into main Feb 3, 2025
3 checks passed
@cp-20 cp-20 deleted the feat/template-rich-metrics branch February 3, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirosiki197 pirosiki197 pirosiki197 approved these changes

Assignees

@cp-20 cp-20

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cp-20 @pirosiki197