fix reviews

traP-jp · Feb 3, 2025 · 28ad2e0 · 28ad2e0
1 parent 28bee0a
commit 28ad2e0
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 24 deletions.
diff --git a/template/cache.go b/template/cache.go
@@ -43,7 +43,7 @@ func (c *cacheWithInfo) isNewerThan(key string, t int64) bool {
 }
 
 func (c *cacheWithInfo) RecordReplaceTime(time time.Duration) {
-	c.replaceTime.Add(int64(time))
+	c.replaceTime.Add(time.Nanoseconds())
 }
 
 type (

diff --git a/template/cache.tmpl b/template/cache.tmpl
@@ -41,7 +41,7 @@ func (c *cacheWithInfo) isNewerThan(key string, t int64) bool {
 }
 
 func (c *cacheWithInfo) RecordReplaceTime(time time.Duration) {
-	c.replaceTime.Add(int64(time))
+	c.replaceTime.Add(time.Nanoseconds())
 }
 
 type (

diff --git a/template/driver.go b/template/driver.go
@@ -8,7 +8,6 @@ import (
 	"io"
 	"log"
 	"strings"
-	"sync/atomic"
 	"time"
 
 	"github.com/go-sql-driver/mysql"
@@ -53,20 +52,18 @@ func init() {
 		conditions := query.Select.Conditions
 		if isSingleUniqueCondition(conditions, query.Select.Table) {
 			caches[normalized] = &cacheWithInfo{
-				Cache:       sc.NewMust(replaceFn, 10*time.Minute, 10*time.Minute),
-				query:       normalized,
-				info:        *query.Select,
-				uniqueOnly:  true,
-				replaceTime: atomic.Int64{},
+				Cache:      sc.NewMust(replaceFn, 10*time.Minute, 10*time.Minute),
+				query:      normalized,
+				info:       *query.Select,
+				uniqueOnly: true,
 			}
 			continue
 		}
 		caches[query.Query] = &cacheWithInfo{
-			Cache:       sc.NewMust(replaceFn, 10*time.Minute, 10*time.Minute),
-			query:       query.Query,
-			info:        *query.Select,
-			uniqueOnly:  false,
-			replaceTime: atomic.Int64{},
+			Cache:      sc.NewMust(replaceFn, 10*time.Minute, 10*time.Minute),
+			query:      query.Query,
+			info:       *query.Select,
+			uniqueOnly: false,
 		}
 
 		// TODO: if query is like "SELECT * FROM WHERE pk IN (?, ?, ...)", generate cache with query "SELECT * FROM table WHERE pk = ?"

diff --git a/template/driver.tmpl b/template/driver.tmpl
@@ -49,22 +49,20 @@ func init() {
 		}
 
 		conditions := query.Select.Conditions
-		if isSingleUniqueCondition(conditions, query.Select.Table) {
+			if isSingleUniqueCondition(conditions, query.Select.Table) {
 			caches[normalized] = &cacheWithInfo{
-				Cache:       sc.NewMust(replaceFn, 10*time.Minute, 10*time.Minute),
-				query:       normalized,
-				info:        *query.Select,
-				uniqueOnly:  true,
-				replaceTime: atomic.Int64{},
+				Cache:      sc.NewMust(replaceFn, 10*time.Minute, 10*time.Minute),
+				query:      normalized,
+				info:       *query.Select,
+				uniqueOnly: true,
 			}
 			continue
 		}
 		caches[query.Query] = &cacheWithInfo{
-			Cache:       sc.NewMust(replaceFn, 10*time.Minute, 10*time.Minute),
-			query:       query.Query,
-			info:        *query.Select,
-			uniqueOnly:  false,
-			replaceTime: atomic.Int64{},
+			Cache:      sc.NewMust(replaceFn, 10*time.Minute, 10*time.Minute),
+			query:      query.Query,
+			info:       *query.Select,
+			uniqueOnly: false,
 		}
 
 		// TODO: if query is like "SELECT * FROM WHERE pk IN (?, ?, ...)", generate cache with query "SELECT * FROM table WHERE pk = ?"
-Original file line number
+Diff line change
@@ Expand Up @@
     }
     func (c *cacheWithInfo) RecordReplaceTime(time time.Duration) {
-    	c.replaceTime.Add(int64(time))
+    	c.replaceTime.Add(time.Nanoseconds())
     }
     type (
@@ Expand Down @@