Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update zi and zinit update to use parallel flag #857

Closed
wants to merge 1 commit into from

Conversation

taymoork2
Copy link

@taymoork2 taymoork2 commented Jul 8, 2024

What does this PR do

Speeds up zi and zinit update commands by adding parallel flag

Standards checklist

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, we already tried this, and it did not seem to work, see: #709

@taymoork2
Copy link
Author

Is there a way to test this change with the config file before I install rust and debug that way
Dont think theres a way to patch the currently binary installed w/ brew?

@SteveLauC
Copy link
Member

Is there a way to test this change with the config file before I install rust and debug that way Dont think theres a way to patch the currently binary installed w/ brew?

I guess no, you need to build it from src.

@SteveLauC
Copy link
Member

BTW, if you want to test this parallel option, try Topgrade v14.0.0 or v14.0.1, it was added in v14.0.0 and removed in v15.0.0.

@SteveLauC
Copy link
Member

Close as this is not planned, but feel free to reopen it if you still think we should add it.

@SteveLauC SteveLauC closed this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants