Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist pets across windows/workspaces when using the explorer position #652

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thanasibakis
Copy link

There seems to be a good amount of interest (#409, #543, #587, #643, and myself!) in having pets saved to a global state when the extension is operating in the explorer position. So, I've taken a stab at that.

I've repurposed the vscode-pets.start command slightly, so that it also removes all currently visible pets and loads them from the memento, in the same way that the panel position mode does.
I've also instructed the extension to run the vscode-pets.start command when the explorer view is first resolved.

A couple notes:

  • The behavior of the panel position mode (which already persists in global state) has not been modified.
  • As the implementation currently stands, any pets the user currently has in the workspace state are ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant