Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nightly build #304

Merged
merged 4 commits into from
Apr 18, 2024
Merged

fix nightly build #304

merged 4 commits into from
Apr 18, 2024

Conversation

sabify
Copy link
Contributor

@sabify sabify commented Mar 4, 2024

mcginty
mcginty approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@mcginty mcginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

bschwind
bschwind approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@bschwind bschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well, let's see if we can get CI to cooperate.

@sabify
Copy link
Contributor Author

sabify commented Mar 5, 2024

Those Clippy errors were not related to this PR, but I tried to fix them.

@skywhale
Copy link
Member

Let me go ahead and merge this 🙏

@skywhale skywhale merged commit 1560238 into tonarino:main Apr 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschwind bschwind bschwind approved these changes

@mcginty mcginty mcginty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sabify @skywhale @mcginty @bschwind