Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publicip: fix IPv4 resolution on macOS #275

Merged
merged 1 commit into from
Jul 10, 2023
Merged

publicip: fix IPv4 resolution on macOS #275

merged 1 commit into from
Jul 10, 2023

Conversation

mcginty
Copy link
Collaborator

@mcginty mcginty commented Jul 7, 2023

macOS isn't happy with using the IPv6 unspecified address when routing over the IPv4 stack.

Copy link
Member

@strohel strohel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschwind
Copy link
Member

bschwind commented Jul 8, 2023

Wondering why this is now failing in the docker tests...is it because we're now binding to an IPV4 address instead of IPV6?

@strohel
Copy link
Member

strohel commented Jul 9, 2023

@bschwind Dockers tests are failing also in main for some time, so that should be independent. (but yeah we should have a look)

Copy link
Member

@bschwind bschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, didn't realize the tests are failing in main. Weird that they started after we released 1.60 and essentially just changed some shell completion files...

Anyway, this code looks good!

@strohel strohel merged commit 5eaad11 into main Jul 10, 2023
@strohel strohel deleted the publicip-ipv4-macos branch July 10, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants