Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of client code into a library #132

Closed
wants to merge 1 commit into from

Conversation

bramvdbogaerde
Copy link

@bramvdbogaerde bramvdbogaerde commented Aug 18, 2021

This pull request tracks the progress on refactoring the Innernet client side (see issue #126).

It proposes the following changes:

  • Rename the client crate to the cli create to make the distinction between multiple frontend clearer
  • Create a client library crate which will host the code shared between frontends
  •  Move the API calls into the client library
  •  Move common code (such as the loop that periodically updates peers, adding peers, ...) into the client library
  •  Create a Store crate which can be used to keep track of Innernet's local state in a platform and frontend agnostic way, the sole implementation of this trait will initially be the already implemented file backed store

These are the initial proposed set of changes, it should make it easier to extend Innernet with more interaction surfaces that can be decoupled from the main Innernet codebase.

Comments and feedback are greatly appreciated.

@mcginty
Copy link
Collaborator

mcginty commented Aug 25, 2021

Thanks for kicking this off! I think this is the right way forward, including breaking up the client into a couple of logically separated crates (and moving some of the current workspace crates out into their own repositories and putting them on crates.io).

Looks good so far. How can I help?

@mcginty
Copy link
Collaborator

mcginty commented Nov 11, 2021

I'm going to go ahead and close this until there's an active effort. Thanks for getting the conversation started @bramvdbogaerde!

@mcginty mcginty closed this Nov 11, 2021
@bramvdbogaerde
Copy link
Author

Indeed, I didn't have the time to progress this much further. I might reopen it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants