Added Support for MS SQL Server #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tombenner Are there any plans on merging in this pull request? I would find it useful for a project that I am doing. |
|
Sorry for the delay! I'd be happy to accept this, but we'll want to make sure that it's tested. This should be fairly easy/quick to do; appraisals for MS SQL Server can be added to the Appraisals file, similar to the existing ones for Postgres and MySQL, and then the tests can be run using @cdhagmann You may want to open a new PR for this, unless @darkstego wants to add it to this PR. |
|
I tried looking into this, but unfortunately I get a byebug compilation error whenever I try to run bundler on the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added adapter for MS SQL SERVER