Filter tomatoes by creation date

[potomak]

Closes #241.

[bugant]

How does it handle nil?

[dalpo]

It should work! :)

2.3.3 :001 > nil.to_s
 => ""
2.3.3 :002 > Time.zone.parse ''
 => nil 

[potomak]

Yes, that's how. #parse should work on any string, it returns nil in case of parsing failure. #to_s will convert any params[:from] to a string.

[dalpo]

For me is ok!

The only one thing I'd like to change is creating a common scope for sorting tomatoes.

The common use case is sorting tomatoes by creation:
So we can create something like this:

scope :sorted_desc, -> { order_by([[:created_at, :desc], [:_id, :desc]]) }

[dalpo]

It should work! :)

2.3.3 :001 > nil.to_s
 => ""
2.3.3 :002 > Time.zone.parse ''
 => nil 

[dalpo]

Why don't you create a scope for sorting tomatoes?

[dalpo]

If you create a scope for sorting, you can reuse it here too :)

[potomak]

Yes @dalpo, I wanted to create such a scope, but I didn't find a good name for it. sorted_desc is not descriptive enough. I thought of reverse_chronological_order, but it's too long. I though of latest_first or freshest_first, but they have first in them that seem like a selection of the first element. I thought of created_at_desc, but it wouldn't include the second sorting condition on _id.

[dalpo]

I like sorted by #freshest tomatoes 😄
...but It's not a good name.

Maybe simply: Tomato.descendants? I think it's self explanatory enough.

[potomak]

@dalpo naming is too hard! I'll leave this task for another PR. I created a proposal where we can discuss on an appropriate name for the scope: #256.