My first set of patches #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use a path matcher method instead. This seems to be the more standard way of matching for USB serial devices as the vendor code's all tend to be generic anyway. Fixed several concurrency problems, you must set state BEFORE initiating something that affects that state asynchronously. The delegate for the serial framework wasn't being set in the right place so none of the call backs were working to trigger the state changes as responses came back. Cleaned up the initialize code to be able to handle getting "wait", "e1" and "B004" messages. These needed either the M115 to be re-sent or a "Q" and the M115 to be resent. Ugly for now but I wanted to see the head move on the printer. And move it did. Now working on how you slice for this thing and have it stick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for trying to find US vendor ID's didn't work, couldn't find USBInterface. So I used a path matcher method instead. This seems to be the more standard way of matching for USB serial devices as the vendor code's all tend to be generic anyway.
Fixed several concurrency problems, you must set state BEFORE initiating something that affects that state asynchronously eg set the call back then call the thing that will call the call back when it's done.
The delegate for the serial framework wasn't being set in the right place so none of the call backs were working to trigger the state changes as responses came back.
Cleaned up the initialize code to be able to handle getting "wait", "e1" and "B004" messages. These needed either the M115 to be re-sent or a "Q" and the M115 to be resent. Ugly for now but I wanted to see the head move on the printer. And move it did. Now working on how you slice for this thing and have it stick.