Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): add more open doc options to editor toolbar #9588

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jan 8, 2025

Copy link
Collaborator Author

pengx17 commented Jan 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pengx17 pengx17 marked this pull request as ready for review January 8, 2025 09:16
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 54.62963% with 49 lines in your changes missing coverage. Please review.

Project coverage is 52.77%. Comparing base (890a962) to head (f78857b).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ne/presets/nodes/reference-node/reference-popup.ts 42.10% 11 Missing ⚠️
...idgets/element-toolbar/change-embed-card-button.ts 52.94% 8 Missing ⚠️
...-block/widgets/element-toolbar/more-menu/config.ts 66.66% 8 Missing ⚠️
packages/frontend/core/src/utils/event.ts 0.00% 8 Missing ⚠️
...k/widgets/embed-card-toolbar/embed-card-toolbar.ts 53.84% 6 Missing ⚠️
...c/embed-linked-doc-block/embed-linked-doc-block.ts 60.00% 4 Missing ⚠️
...inked-doc-block/embed-edgeless-linked-doc-block.ts 50.00% 2 Missing ⚠️
...c/embed-synced-doc-block/embed-synced-doc-block.ts 50.00% 1 Missing ⚠️
blocksuite/affine/shared/src/utils/event.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9588      +/-   ##
==========================================
- Coverage   52.97%   52.77%   -0.21%     
==========================================
  Files        2178     2178              
  Lines       98039    98094      +55     
  Branches    16689    16667      -22     
==========================================
- Hits        51940    51765     -175     
- Misses      44686    44881     +195     
- Partials     1413     1448      +35     
Flag Coverage Δ
server-test 77.81% <ø> (-0.77%) ⬇️
unittest 32.36% <14.81%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/01-08-fix_ios_ignore_some_build_files branch from 4cb25c3 to b13b339 Compare January 8, 2025 15:02
@pengx17 pengx17 requested a review from a team as a code owner January 8, 2025 15:02
@pengx17 pengx17 force-pushed the xp/01-08-fix_ios_ignore_some_build_files branch from b13b339 to f6c5867 Compare January 8, 2025 15:03
@github-actions github-actions bot added the mod:i18n Related to i18n label Jan 8, 2025
@pengx17 pengx17 changed the title fix(ios): ignore some build files feat(editor): add more open doc options to editor toolbar Jan 8, 2025
@pengx17 pengx17 force-pushed the xp/01-08-fix_ios_ignore_some_build_files branch 3 times, most recently from 11f2c9d to 390786b Compare January 9, 2025 02:54
Copy link
Contributor

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧰

@pengx17 pengx17 force-pushed the xp/01-08-fix_ios_ignore_some_build_files branch 6 times, most recently from 8dc096c to 8bec475 Compare January 9, 2025 05:08
@pengx17 pengx17 force-pushed the xp/01-08-fix_ios_ignore_some_build_files branch 3 times, most recently from b4d7834 to c8623f5 Compare January 9, 2025 06:45
@github-actions github-actions bot added the test Related to test cases label Jan 9, 2025
@pengx17 pengx17 force-pushed the xp/01-08-fix_ios_ignore_some_build_files branch 2 times, most recently from 5d2a8e0 to 7c50e3d Compare January 9, 2025 07:14
Copy link

graphite-app bot commented Jan 9, 2025

Merge activity

@pengx17 pengx17 force-pushed the xp/01-08-fix_ios_ignore_some_build_files branch from 7c50e3d to f78857b Compare January 9, 2025 08:04
@graphite-app graphite-app bot merged commit f78857b into canary Jan 9, 2025
61 checks passed
@graphite-app graphite-app bot deleted the xp/01-08-fix_ios_ignore_some_build_files branch January 9, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants